From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Ingo Molnar <mingo@kernel.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, dvhart@infradead.org, andy.shevchenko@gmail.com,
boon.leong.ong@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000
Date: Thu, 29 Jan 2015 13:27:20 +0000 [thread overview]
Message-ID: <54CA3538.3000404@nexus-software.ie> (raw)
In-Reply-To: <20150129074411.GA4817@gmail.com>
On 29/01/15 07:44, Ingo Molnar wrote:
Hi Ingo.
I'll transmit those changes in with the following exception
>> + ret = imr_write(idev, reg, &imr, false);
>
> So 'ret' here gets mixed with other potential failure modes.
>
> If imr_write() fails here then that's a highly anomalous internal
> failure - so it might be better to add a WARN_ON(ret) or so.
>
imr_write() already does a WARN - so no need to do it again.
next prev parent reply other threads:[~2015-01-29 13:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 18:36 [PATCH v6 0/2] x86: Add IMR support to Quark/Galileo Bryan O'Donoghue
2015-01-28 18:36 ` [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000 Bryan O'Donoghue
2015-01-29 5:38 ` Darren Hart
2015-01-29 7:44 ` Ingo Molnar
2015-01-29 10:08 ` Andy Shevchenko
2015-01-29 10:12 ` Bryan O'Donoghue
2015-01-29 13:47 ` Ong, Boon Leong
2015-01-29 15:22 ` Bryan O'Donoghue
2015-01-29 15:32 ` Ong, Boon Leong
2015-01-29 15:40 ` Bryan O'Donoghue
2015-01-29 16:12 ` Bryan O'Donoghue
2015-01-29 16:26 ` Ong, Boon Leong
2015-01-29 15:15 ` Ong, Boon Leong
2015-01-29 13:27 ` Bryan O'Donoghue [this message]
2015-01-29 9:59 ` Ong, Boon Leong
2015-01-28 18:36 ` [PATCH 2/2] x86, quark: Add Intel Quark platform support Bryan O'Donoghue
-- strict thread matches above, loose matches on Subject: below --
2014-12-29 17:23 [PATCH 0/2] x86: Add IMR support to Quark/Galileo Bryan O'Donoghue
2014-12-29 17:23 ` [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000 Bryan O'Donoghue
2014-12-31 15:05 ` Andy Shevchenko
2015-01-01 20:11 ` Bryan O'Donoghue
2015-01-06 7:36 ` Darren Hart
2015-01-06 13:43 ` Bryan O'Donoghue
2015-01-06 16:54 ` Darren Hart
2015-01-07 23:45 ` Ong, Boon Leong
2015-01-08 12:10 ` Bryan O'Donoghue
2015-01-08 14:52 ` Ong, Boon Leong
2015-01-08 0:04 ` Ong, Boon Leong
2015-01-08 13:08 ` Bryan O'Donoghue
2015-01-08 14:45 ` Ong, Boon Leong
2015-01-08 15:11 ` Bryan O'Donoghue
2015-01-09 3:44 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA3538.3000404@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=andy.shevchenko@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.