From: Eric Blake <eblake@redhat.com>
To: Peter Krempa <pkrempa@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3 1/2] vl.c: Fix error messages when parsing maxmem parameters
Date: Thu, 29 Jan 2015 06:57:31 -0700 [thread overview]
Message-ID: <54CA3C4B.1060103@redhat.com> (raw)
In-Reply-To: <d4c62f77fc98e21a66faa3fb362b1a33f0d23131.1422539139.git.pkrempa@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On 01/29/2015 06:48 AM, Peter Krempa wrote:
> Produce more human readable error messages and fix few spelling
> mistakes.
>
> Also remove a redundant check for the max memory size.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>
> Notes:
> Version 3:
> - forgot a word in one of the error messages
>
> Version 2:
> - fixed spacing in error message
> - changed control flow to allow maxmem == ram_size in case slots == 0
>
> vl.c | 34 ++++++++++++++++------------------
> 1 file changed, 16 insertions(+), 18 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-29 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 13:48 [Qemu-devel] [PATCHv3 0/2] pc: Fix startup with memory hotplug enabled Peter Krempa
2015-01-29 13:48 ` [Qemu-devel] [PATCHv3 1/2] vl.c: Fix error messages when parsing maxmem parameters Peter Krempa
2015-01-29 13:57 ` Eric Blake [this message]
2015-01-29 13:48 ` [Qemu-devel] [PATCHv3 2/2] pc: memory: Validate alignment of maxram_size to page size Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA3C4B.1060103@redhat.com \
--to=eblake@redhat.com \
--cc=mst@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.