From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 1/2] x86/VPMU: Disable VPMU when NMI
	watchdog is on
Date: Thu, 29 Jan 2015 10:25:07 -0500
Message-ID: <54CA50D3.40203@oracle.com>
References: <1422474991-2001-1-git-send-email-boris.ostrovsky@oracle.com>
	<1422474991-2001-2-git-send-email-boris.ostrovsky@oracle.com>
	<54CA2B90020000780005AC70@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1YGqyH-0003z1-PQ
	for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 15:25:29 +0000
In-Reply-To: <54CA2B90020000780005AC70@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, kevin.tian@intel.com, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On 01/29/2015 06:46 AM, Jan Beulich wrote:
>>>> On 28.01.15 at 20:56, <boris.ostrovsky@oracle.com> wrote:
>> @@ -59,6 +60,12 @@ static void __init parse_vpmu_param(char *s)
>>           }
>>           /* fall through */
>>       case 1:
>> +        if ( opt_watchdog )
>> +        {
>> +            printk("NMI watchdog is enabled. Disabling VPMU\n");
>> +            opt_vpmu_enabled = 0;
>> +            break;
>> +        }
>>           opt_vpmu_enabled |= VPMU_BOOT_ENABLED;
>>           break;
>>       }
>
> Not only to address Andrew's concerns this needs to be changed:
> Logging messages from cmdline argument parsing functions is only
> marginally useful - they won't appear on the serial console. But
> afaict that'll go away anyway by consolidating the patch into simply
> checking opt_watchdog from vPMU code.



Not on the console, but the do show up in the log:

root@haswell> xl dmesg|grep -i vpmu
(XEN) NMI watchdog is enabled. Disabling VPMU
(XEN) Command line: placeholder conring_size=512k loglvl=all 
sync_console=true flask_enforcing=1 com1=38400,8n1,pci console=com1 
watchdog vpmu
root@haswell>

But regardless, I am going to do the opt_watchdog check in VPMU init code.

-boris