From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrX4-0005ao-MG for qemu-devel@nongnu.org; Thu, 29 Jan 2015 11:01:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGrWz-00037W-On for qemu-devel@nongnu.org; Thu, 29 Jan 2015 11:01:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrWz-00037R-Fn for qemu-devel@nongnu.org; Thu, 29 Jan 2015 11:01:21 -0500 Message-ID: <54CA594E.5030605@redhat.com> Date: Thu, 29 Jan 2015 09:01:18 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <54CA500E.8030608@redhat.com> <20150129155425.GE2391@work-vm> In-Reply-To: <20150129155425.GE2391@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wscLdV0rn0uvvl6W5kFtHdBwk7gVwexX9" Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wscLdV0rn0uvvl6W5kFtHdBwk7gVwexX9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2015 08:54 AM, Dr. David Alan Gilbert wrote: >> The idea of a QMP command to trigger incoming migration looks >> reasonable. We can probably use a qapi union for a nicer syntax, >> something like: >> >> {"execute": "migrate-incoming", "arguments": { >> "type": "tcp", "port": 44 } } >> vs. >> {"execute": "migrate-incoming", "arguments": { >> "type": "fd", "fd": 0 } } >> vs. >> {"execute": "migrate-incoming", "arguments": { >> "type": "exec", "command": [ "cat", "/path/to/file" ] } } >> >> and so forth. >=20 > Compared to just taking a URI argument that Dan suggested, that's quite= a > bit of rework to do the reworking of each transport which is pretty > trivial. Yes, but getting the interface right means that adding future extensions will be easier, with less string parsing hacks. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wscLdV0rn0uvvl6W5kFtHdBwk7gVwexX9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyllOAAoJEKeha0olJ0NqcIYIAJA3aHRP3iztUpU/DcXJ85J8 XEAFRWbKfnl1Tp12cg8bN2QyuAg1m97/WpGgzv5k80D2doPbcLgekLoy3qUznOGX G04AzKtuTmDL9R6HcrBom4HfbLJBjk+XHZj2KBGOglBVvRYMRR5Rn/LiMwmGWVkZ bKRb+d2kadZyzK8xETBm4JduHSydy+mwTLfTgtmB6bVfx+BODOJIJGEvjGsJQE59 Zs9xzY07qZSy/YNhjV6acHCNi1VFCdQR6uCYr7oYaHqq9cIZLBuxrCsqCWAX30He vZ0rNvFJiF/yt/zzHMWMV/5VFRNAXKAnXphadfc3xCoUXtrj0wwKv0RWO5bKuAU= =Q7hs -----END PGP SIGNATURE----- --wscLdV0rn0uvvl6W5kFtHdBwk7gVwexX9--