From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 0/6] xen/arm: Move in/out code to/from init section Date: Fri, 30 Jan 2015 11:33:33 +0000 Message-ID: <54CB6C0D.8080007@linaro.org> References: <1421425248-8727-1-git-send-email-julien.grall@linaro.org> <54CA7CBB.7050308@linaro.org> <1422617430.12551.9.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YH9pq-0001zK-H0 for xen-devel@lists.xenproject.org; Fri, 30 Jan 2015 11:34:03 +0000 Received: by mail-wi0-f178.google.com with SMTP id bs8so2078802wib.5 for ; Fri, 30 Jan 2015 03:34:01 -0800 (PST) In-Reply-To: <1422617430.12551.9.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 30/01/15 11:30, Ian Campbell wrote: > On Thu, 2015-01-29 at 18:32 +0000, Julien Grall wrote: >> Hello, >> >> Ping? Any more review for this version of this series? > > I was awaiting a version with the declarations in the right places as > pointed out by Andy (including his point about definition vs. prototype > I'm afraid, which is the style we use). I'm not convince about your last point. We have many places (if not all on ARM) where __init is used in the header. Some of them was even added by you ;). So I would prefer if we keep them, it's more readable. FWIW Linux does it too. Regards, -- Julien Grall