From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH linux-2.6.18] support suspend/resume in pvscsi drivers Date: Fri, 30 Jan 2015 15:54:15 +0100 Message-ID: <54CB9B17.40901@suse.com> References: <1422625932-30037-1-git-send-email-jgross@suse.com> <54CBA747020000780005B636@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YHCxe-0004pA-8L for xen-devel@lists.xenproject.org; Fri, 30 Jan 2015 14:54:18 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E476BAC16 for ; Fri, 30 Jan 2015 14:54:15 +0000 (UTC) In-Reply-To: <54CBA747020000780005B636@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 01/30/2015 03:46 PM, Jan Beulich wrote: >>>> On 30.01.15 at 14:52, <"jgross@suse.com".non-mime.internet> wrote: >> @@ -231,8 +242,23 @@ static int scsifront_cmd_done(struct vsc >> return more_to_do; >> } >> >> +void scsifront_finish_all(struct vscsifrnt_info *info) >> +{ >> + unsigned i; >> + struct vscsiif_response resp; >> >> + scsifront_ring_drain(info); > > Shouldn't you at least issue some kind of warning when this returns > non-zero? If a warning should be issued, then this should be done after the following loop in case of at least one request terminated there. I'm really not sure, whether a warning is required here. If you like, I can add one. Juergen