From: "Tom G. Christensen" <tgc@statsbiblioteket.dk>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: Handle broken curl version number in version check
Date: Fri, 30 Jan 2015 16:34:47 +0100 [thread overview]
Message-ID: <54CBA497.7040804@statsbiblioteket.dk> (raw)
In-Reply-To: <87wq44gw4y.fsf@igel.home>
On 30/01/15 15:50, Andreas Schwab wrote:
> "Tom G. Christensen" <tgc@statsbiblioteket.dk> writes:
>
>> diff --git a/Makefile b/Makefile
>> index c44eb3a..69a2ce3 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1035,13 +1035,13 @@ else
>> REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
>> PROGRAM_OBJS += http-fetch.o
>> PROGRAMS += $(REMOTE_CURL_NAMES)
>> - curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)
>> + curl_check := $(shell (echo 070908; curl-config --vernum | sed -e '/^70[B-C]/ s/^7/07/') 2>/dev/null | sort -r | sed -ne 2p)
>
> How about 's/^.....$/0&/' ?
>
I have no preference so whatever is the most likely to be accepted and
does the job is fine with me.
-tgc
next prev parent reply other threads:[~2015-01-30 15:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 23:35 [ANNOUNCE] Git v2.3.0-rc2 Junio C Hamano
2015-01-29 12:58 ` Broken makefile check for curl version on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2] Tom G. Christensen
2015-01-30 9:52 ` [PATCH] Makefile: Handle broken curl version number in version check Tom G. Christensen
2015-01-30 14:50 ` Andreas Schwab
2015-01-30 15:34 ` Tom G. Christensen [this message]
2015-01-30 15:41 ` Kyle J. McKay
2015-01-30 22:09 ` Junio C Hamano
2015-01-29 13:11 ` All gnupg tests broken on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2] Tom G. Christensen
2015-01-29 15:43 ` Jeff King
2015-01-29 15:51 ` Jeff King
2015-01-29 17:34 ` Tom G. Christensen
2015-01-29 18:48 ` Junio C Hamano
2015-01-29 13:30 ` Testsuite regression with perl 5.8.0 " Tom G. Christensen
2015-01-29 15:52 ` Jeff King
2015-01-30 9:53 ` Tom G. Christensen
2015-01-30 6:24 ` [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-' Tom G. Christensen
2015-01-30 23:05 ` brian m. carlson
2015-01-31 2:40 ` Kyle J. McKay
2015-02-02 1:33 ` Junio C Hamano
2015-02-02 16:11 ` Kyle J. McKay
2015-02-02 20:12 ` Junio C Hamano
2015-02-12 23:12 ` Junio C Hamano
2015-02-13 20:19 ` [PATCH 0/2] Getopt::Long workaround in send-email Junio C Hamano
2015-02-13 20:19 ` [PATCH 1/2] git-send-email.perl: support no- prefix with older GetOptions Junio C Hamano
2015-02-15 6:32 ` Brandon Casey
[not found] ` <031750B1-259D-4F19-8484-98A7A1266248@gmail.com>
2015-02-16 1:35 ` Brandon Casey
2015-02-13 20:19 ` [PATCH 2/2] SQUASH??? t9001: turn --no$option workarounds to --no-$option Junio C Hamano
2015-02-13 20:30 ` [PATCH 0/2] Getopt::Long workaround in send-email Kyle J. McKay
2015-02-13 22:21 ` brian m. carlson
2015-02-15 6:13 ` Brandon Casey
2015-02-16 9:58 ` Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBA497.7040804@statsbiblioteket.dk \
--to=tgc@statsbiblioteket.dk \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.