From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform Date: Fri, 30 Jan 2015 15:52:20 +0000 Message-ID: <54CBA8B4.7090405@linaro.org> References: <1422027220-31423-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <1422027220-31423-4-git-send-email-oleksandr.tyshchenko@globallogic.com> <1422451579.14124.39.camel@citrix.com> <1422454596.5187.7.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Oleksandr Tyshchenko , Ian Campbell Cc: Stefano Stabellini , Tim Deegan , Andrii Anisov , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Hi Oleksandr, On 30/01/15 15:38, Oleksandr Tyshchenko wrote: > For example, such a simple thing as a formula for calculating divider > value for uart baudrate can differs from one family to > another despite the fact that these families use the same UART IP > block named SCIF (clock may be differs - ext/int, another freq). > Or FIFO size, etc. IHMO this look more configuration than logic change in the UART driver. We don't ask you to support all the configuration of the UART right now ;). However, if someone comes with a new platform using the SCIF, I expect him to reuse and fix this driver rather than creating a new one. FWIW, the compatible string is "renesas,scif" not rcar smth. So, SCIF sounds a better name for this UART. Regards, -- Julien Grall