From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 3/3] xen/arm: Introduce support for
 Renesas R-Car Gen2 platform
Date: Fri, 30 Jan 2015 16:52:41 +0000
Message-ID: <54CBB6D9.6000206@linaro.org>
References: <1422027220-31423-1-git-send-email-oleksandr.tyshchenko@globallogic.com>	<1422027220-31423-4-git-send-email-oleksandr.tyshchenko@globallogic.com>	<1422451579.14124.39.camel@citrix.com>	<CAJEb2DHpw33EnXsviv+w3Pij6XKLRESrAc-WKM2OadNxLF3+2Q@mail.gmail.com>	<1422454596.5187.7.camel@citrix.com>	<CAGQvs6ihm_jiVm2GoQupNthVE3-Rb=zbrjAsgdQ6dDh7e=hOtg@mail.gmail.com>	<CAJEb2DH6bJwCjwwgS-SXUgSMiAnZ-8rfswk3RzuYUjQP+4FH9A@mail.gmail.com>	<54CBA8B4.7090405@linaro.org>
	<CAJEb2DEBninJAjLJnVWSgg_npHsHH3UmTfb6MBqgSwqUdhMOjw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAJEb2DEBninJAjLJnVWSgg_npHsHH3UmTfb6MBqgSwqUdhMOjw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Andrii Anisov <andrii.anisov@globallogic.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 30/01/15 16:44, Oleksandr Tyshchenko wrote:
> On Fri, Jan 30, 2015 at 5:52 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> Hi Oleksandr,
> Hi Julien
> 
>>
>> On 30/01/15 15:38, Oleksandr Tyshchenko wrote:
>>> For example, such a simple thing as a formula for calculating divider
>>> value for uart baudrate can differs from one family to
>>> another despite the fact that these families use the same UART IP
>>> block named SCIF (clock may be differs - ext/int, another freq).
>>> Or FIFO size, etc.
>>
>> IHMO this look more configuration than logic change in the UART driver.
>> We don't ask you to support all the configuration of the UART right now
>> ;). However, if someone comes with a new platform using the SCIF, I
>> expect him to reuse and fix this driver rather than creating a new one.
>>
>> FWIW, the compatible string is "renesas,scif" not rcar smth. So, SCIF
>> sounds a better name for this UART.
> ok
> 
> Just to clarify:
> - Should I remove all references to "R-Car Gen2" from UART stuff?

Yes please.

> - Can I keep your "Reviewed-by" after there mechanical changes.

Sure.

> It would be nice to hear your and Ian's opinions about board file.

I'm not sure about this one. I will let Ian decides.

Regards,

-- 
Julien Grall