From: Lars-Peter Clausen <lars@metafoo.de>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Add sysfs entries via static attribute groups
Date: Fri, 30 Jan 2015 18:27:05 +0100 [thread overview]
Message-ID: <54CBBEE9.8060007@metafoo.de> (raw)
In-Reply-To: <1422638525-612-1-git-send-email-tiwai@suse.de>
On 01/30/2015 06:22 PM, Takashi Iwai wrote:
[...]
> -
> - if (rtd->codec) {
It looks as if these attributes are now registered unconditionally.
> - /* add DAPM sysfs entries for this codec */
> - ret = snd_soc_dapm_sys_add(rtd->dev);
> - if (ret < 0)
> - dev_err(rtd->dev,
> - "ASoC: failed to add codec dapm sysfs entries: %d\n",
> - ret);
> -
> - /* add codec sysfs entries */
> - ret = device_create_file(rtd->dev, &dev_attr_codec_reg);
> - if (ret < 0)
> - dev_err(rtd->dev,
> - "ASoC: failed to add codec sysfs files: %d\n",
> - ret);
> - }
> -
> return 0;
> }
>
next prev parent reply other threads:[~2015-01-30 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 17:22 [PATCH] ASoC: Add sysfs entries via static attribute groups Takashi Iwai
2015-01-30 17:27 ` Lars-Peter Clausen [this message]
2015-01-30 17:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBBEE9.8060007@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.