From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFcr-0003OM-3x for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:45:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFcm-0004Lf-7J for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:45:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFcl-0004Lb-Vl for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:44:56 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UHitMn029075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 30 Jan 2015 12:44:55 -0500 Message-ID: <54CBC316.8020207@redhat.com> Date: Fri, 30 Jan 2015 10:44:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422300468-16216-1-git-send-email-mreitz@redhat.com> <1422300468-16216-15-git-send-email-mreitz@redhat.com> In-Reply-To: <1422300468-16216-15-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X8a451Vrqq1JXac26LHKusPP8Inqwk4fu" Subject: Re: [Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X8a451Vrqq1JXac26LHKusPP8Inqwk4fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 12:27 PM, Max Reitz wrote: > This function first removed the BlockBackend from the blk_backends list= > and cleared its name so it would no longer be found by blk_name(); sinc= e > blk_next() now iterates through monitor_block_backends (which the BB is= > removed from in do_drive_del()), this is no longer necessary. >=20 > Second, bdrv_make_anon() was called on the BDS. This was intended for > cases where the BDS was owned by that BB alone; in which case the BDS > will no longer exist at this point thanks to the blk_remove_bs() in > do_drive_del(). >=20 > Therefore, this function does nothing useful anymore. Remove it. >=20 > Signed-off-by: Max Reitz > --- > block/block-backend.c | 25 ++----------------------- > blockdev.c | 1 - > include/sysemu/block-backend.h | 2 -- > 3 files changed, 2 insertions(+), 26 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --X8a451Vrqq1JXac26LHKusPP8Inqwk4fu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUy8MWAAoJEKeha0olJ0NqDsAH/1h9dJfAGYquFSDLslUJWdCx QXl6fzqJHM1q8zTmqXdjRis5lHeYGc0XrsK2HmvTIaOk4A17N1seqmLuA9b76Zz/ AX5WN4a+HwXWG6jexZak9KGKV+S4UKOLLs1uhH+chD9thL/bl+Ajz4k5TFsX21d5 ps/mz2v7URx/BtcHxFIIyrwVCg5eXv5usk/sKYFbPA+H9nW+L1t+UX146dX+zJ4+ SwoGrIyvQoGVE8KpTGd2JIb64yZKAaRzcvmXkkDQ/MGUrNk2U7v1NpHV/M56d3gY lUbGSSrY6Q4odg3434/MvoLr1rIIjF3yOaCe6ANwiaY1WsWSWxSxxjnztzk7xh8= =Z7KG -----END PGP SIGNATURE----- --X8a451Vrqq1JXac26LHKusPP8Inqwk4fu--