From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 3500DE0091D; Fri, 30 Jan 2015 10:49:32 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.171 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 27172E0098D for ; Fri, 30 Jan 2015 10:49:30 -0800 (PST) Received: by mail-we0-f171.google.com with SMTP id k11so26367585wes.2 for ; Fri, 30 Jan 2015 10:49:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=BlIovPsL5XoQvK1joEc5Igpe8gu9soWOh9Qdrue/ylI=; b=Gd6SQ2khMwE5wat/+rxECqxF4YNJhSoQl4Ju3v4apmE5Xaxr9NrXnw95v2mcJ5f0we 0HbfnnQBaw+R+Kih8/+UVRPJT6gaQyhrzLYkzjqxlGLQFb74poicTfx3/qbtiDN4ktdm SarGuPPmVPwpeHMcXwm+ScIIk5XEbPwAh4mY29tLeYP9b6v0jLPUQQMhhlB/39KEFKwc VeKkZ6XBzeEtnEBfIdC7pOnyKAoIIiSB7R7uVmfPdcBFI33WTp0EautFenCUKOR2sf8Q 7fP+5Q0YUsh1xE5g8T7dD+kcXaHQlZWDBoCFShXZeQVd3MjVHSS0IJB7KWLHBI0X1GPf CN9Q== X-Gm-Message-State: ALoCoQk2nfsvVAUP9sNUyfMp1CQ/5g7tsZ+ghGkH186V9Gr6zAuo11yMy9r4AIaEIcQcakCcLFqO X-Received: by 10.180.10.131 with SMTP id i3mr288931wib.54.1422643769657; Fri, 30 Jan 2015 10:49:29 -0800 (PST) Received: from [192.168.2.180] ([83.217.123.106]) by mx.google.com with ESMTPSA id hr1sm8109420wib.1.2015.01.30.10.49.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 10:49:28 -0800 (PST) Message-ID: <54CBD238.1010206@intel.com> Date: Fri, 30 Jan 2015 18:49:28 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: In-Reply-To: Subject: Re: Review of "all machines" page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 18:49:32 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Current work in progress available for testing at poky-contrib michaelw/all-machines (If there's no in-line comment it's an item that's still TODO). Michael On 06/11/14 16:53, Barros Pena, Belen wrote: > I was asked to review the state of all machines page > (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently assigned > to Michael) to give an idea of how much work is left to do. The short > answer is: quite a bit. > > This is the list of issues I've found > > > * The "Show rows" menu doesn't seem to be working properly. When you load > the page, the table always shows 10 rows, independently of the value > selected in the "show rows" menu Fixed > > * The machine name should not have a blue icon next to it Fixed > > * The machine file information is not coming in Unfortunately we have no information available on the machine file that I can find to display > > * The layer name should be a link to the layer details page Fixed > > * The branch, tag or commit column always shows a commit. For machines > coming from layers from the OpenEmbedded layer source, this column should > be showing a branch name instead > > * The help text in the "add layer" buttons is currently hardcoded (it > shows the same layer name for all machines) Fixed > > * You cannot add layers / select machine functionality is not in place Fixed - Apart from the funny tooltip thing > > * The 'layer' column should be sortable (currently isn't) > > * Sorting and the "edit columns" menu do not interact as explained in page > 21 of the design document > > * Sorting by layer source reverts the sorting by machine, setting it to z > to a. This should not happen: when I sort by layer source, machines with > the same layer source should be sorted in alphabetical order (a to z) > > * The "select" column filter is not in place > > * When applying a filter, the page heading does not update to show the > number of results returned by the filter > > * It doesn't look like the search functionality is in place. When you try > to search, you get an error saying that the "Machine object has no > attribute 'search_allowed_fields'". This is the full trace: Think this last one is fixed at least I couldn't reproduce it. The no results state is missing.