All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ding Tianhong <dingtianhong@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>, <netdev@vger.kernel.org>
Cc: David Miller <davem@davemloft.net>,
	Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH] net: hip04: add missing MODULE_LICENSE
Date: Sat, 31 Jan 2015 09:28:30 +0800	[thread overview]
Message-ID: <54CC2FBE.9090107@huawei.com> (raw)
In-Reply-To: <4018099.9I7f6kd5jC@wuerfel>

On 2015/1/31 5:57, Arnd Bergmann wrote:
> The hip04 ethernet driver causes a new compile-time warning
> when built as a loadable module:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/hisilicon/hip04_eth.o
> see include/linux/module.h for more information
> 
> This adds the license as "GPL", which matches the header of the file.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
> index c02b81bcfffb..b72d238695d7 100644
> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c
> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
> @@ -968,3 +968,4 @@ static struct platform_driver hip04_mac_driver = {
>  module_platform_driver(hip04_mac_driver);
>  
>  MODULE_DESCRIPTION("HISILICON P04 Ethernet driver");
> +MODULE_LICENSE("GPL");
> 
> 
Good catch.

Acked-by: Ding Tianhong <dingtianhong@huawei.com>

> 

  reply	other threads:[~2015-01-31  1:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 21:57 [PATCH] net: hip04: add missing MODULE_LICENSE Arnd Bergmann
2015-01-31  1:28 ` Ding Tianhong [this message]
2015-02-03  2:51 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CC2FBE.9090107@huawei.com \
    --to=dingtianhong@huawei.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.