From: Daniel Mack <daniel@zonque.org>
To: Axel Lin <axel.lin@ingics.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matt Ranostay <mranostay@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias
Date: Sat, 31 Jan 2015 10:04:45 +0100 [thread overview]
Message-ID: <54CC9AAD.9060403@zonque.org> (raw)
In-Reply-To: <1422679082.8722.1.camel@phoenix>
On 01/31/2015 05:38 AM, Axel Lin wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded cap11xx modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Daniel Mack <linux@zonque.org>
Thanks!
Daniel
> ---
> drivers/input/keyboard/cap11xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 4f59f0b..f07461a 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
>
> module_i2c_driver(cap11xx_i2c_driver);
>
> -MODULE_ALIAS("platform:cap11xx");
> MODULE_DESCRIPTION("Microchip CAP11XX driver");
> MODULE_AUTHOR("Daniel Mack <linux@zonque.org>");
> MODULE_LICENSE("GPL v2");
>
next prev parent reply other threads:[~2015-01-31 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 4:38 [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias Axel Lin
2015-01-31 9:04 ` Daniel Mack [this message]
2015-01-31 10:17 ` Matt Ranostay
2015-02-01 4:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CC9AAD.9060403@zonque.org \
--to=daniel@zonque.org \
--cc=axel.lin@ingics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.