From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Kuankuan Subject: Re: [PATCH v2 03/12] drm: bridge/dw_hdmi: add irq control to suspend/resume Date: Sat, 31 Jan 2015 06:18:30 -0500 Message-ID: <54CCBA06.8080507@rock-chips.com> References: <1422617031-25098-1-git-send-email-ykk@rock-chips.com> <1422617280-25363-1-git-send-email-ykk@rock-chips.com> <20150131111157.GW26493@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150131111157.GW26493@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: David Airlie , Philipp Zabel , Fabio Estevam , Shawn Guo , Rob Clark , Mark Yao , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, djkurtz@chromium.org, dbehr@chromoum.org, mmind00@googlemail.com, dianders@chromium.org, marcheu@chromium.org, rockchip-discuss@chromium.org List-Id: dri-devel@lists.freedesktop.org On 01/31/2015 06:11 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 06:28:00AM -0500, Yakir Yang wrote: >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 2ded957..13f26af 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -1745,6 +1745,49 @@ void dw_hdmi_unbind(struct device *dev, struct device *master, void *data) >> } >> EXPORT_SYMBOL_GPL(dw_hdmi_unbind); >> >> +int dw_hdmi_suspend(struct platform_device *pdev, pm_message_t state) >> +{ > ... >> +int dw_hdmi_resume(struct platform_device *pdev) >> +{ > Please arrange for these functions to take a struct device rather than > a struct platform_device. The generic part of this driver should remain > bus-agnostic. > > Thanks. okay, is it good to replace "struct platform_device" with "struct device" ? Thanks : )