From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbbAaWN1 (ORCPT ); Sat, 31 Jan 2015 17:13:27 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:49790 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbbAaWNZ (ORCPT ); Sat, 31 Jan 2015 17:13:25 -0500 Message-ID: <54CD537E.9000906@gmail.com> Date: Sat, 31 Jan 2015 22:13:18 +0000 From: Malcolm Priestley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rickard Strandqvist , Forest Bond , Greg Kroah-Hartman CC: =?windows-1252?Q?Guido_Mart=EDnez?= , Guillaume Clement , Veronika Kabatova , Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: dpc: Removed variables that is never used References: <1422717415-6551-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422717415-6551-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/01/15 15:16, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/vt6655/dpc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c > index 977683c..9e9da3c 100644 > --- a/drivers/staging/vt6655/dpc.c > +++ b/drivers/staging/vt6655/dpc.c > @@ -43,7 +43,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb, > struct ieee80211_rx_status rx_status = { 0 }; > struct ieee80211_hdr *hdr; > __le16 fc; > - u8 *rsr, *new_rsr, *rssi; > + u8 *rssi; I rather this was not removed, these are error reporting. I have a patch for them that I will send shortly. Malcolm > __le64 *tsf_time; > u16 frame_size; > int ii, r; > @@ -88,9 +88,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb, > > tsf_time = (__le64 *)(skb_data + bytes_received - 12); > sq = skb_data + bytes_received - 4; > - new_rsr = skb_data + bytes_received - 3; > rssi = skb_data + bytes_received - 2; > - rsr = skb_data + bytes_received - 1; > > RFvRSSITodBm(priv, *rssi, &rx_dbm); > >