From: Jonathan Cameron <jic23@kernel.org>
To: "devendra.aaru" <devendra.aaru@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device
Date: Sun, 01 Feb 2015 10:02:41 +0000 [thread overview]
Message-ID: <54CDF9C1.40202@kernel.org> (raw)
In-Reply-To: <CAHdPZaNNj-54aVhE-rCCg3xqq4tZo=S7n7=ikKWc9GQ6bghhtg@mail.gmail.com>
On 05/01/15 06:12, devendra.aaru wrote:
> On Sun, Jan 4, 2015 at 6:06 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 02/01/15 09:02, Devendra Naga wrote:
>>> This patch adds the error handling for the value returned from
>>> ade7754_spi_read_reg_8. With this patch, the following randconfig
>>> warnings get fixed automatically.
>>>
>>> drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>> drivers/staging/iio/meter/ade7754.c:368:6: warning: ‘val’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>> Looks good to me. A Hartmut reviewed the original patch I'll leave it
>> a few days to see if he wants to take a look at the update.
>>
>> Thanks,
>>
>> Jonathan
>>> ---
>
> Thanks for the review Jonathan.
Applied to the togreg branch of iio.git. These have missed the
merge window for this cycle (sorry, I forgot about them!)
Anyhow, will get queued up for after the window closes.
J
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-02-01 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 9:02 [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device Devendra Naga
2015-01-02 9:02 ` [PATCH V2 2/2] iio: meter: ade7759: " Devendra Naga
2015-02-01 10:10 ` Jonathan Cameron
2015-01-04 11:06 ` [PATCH V2 1/2] iio: meter: ade7754: " Jonathan Cameron
2015-01-05 6:12 ` devendra.aaru
2015-02-01 10:02 ` Jonathan Cameron [this message]
2015-01-05 5:57 ` sanjeev sharma
2015-02-01 10:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CDF9C1.40202@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.