From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39049)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1YHyxp-0004d3-6y
	for qemu-devel@nongnu.org; Sun, 01 Feb 2015 13:09:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1YHyxo-0003lc-BT
	for qemu-devel@nongnu.org; Sun, 01 Feb 2015 13:09:41 -0500
Message-ID: <54CE6BD8.6000305@ilande.co.uk>
Date: Sun, 01 Feb 2015 18:09:28 +0000
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <1421704772-10394-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1421704772-10394-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 0/4] timer/m48t59: QOM'ify
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org
Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>, qemu-ppc@nongnu.org

On 19/01/15 21:59, Hervé Poussineau wrote:

> Hi,
> 
> This patchset QOM'ifies the m48t59 timer.
> Patch 1 allows the creation of the m4859 ISA device from the command line.
> Patch 2 QOM'ifies the device.
> Patches 3 add a Nvram interface to m48txx devices, so that callers can
> detect the device and use it without knowing m48txx internals.
> Patch 4 is using this new Nvram interface and cleaning the m48t59 header.
> 
> Patches 3 and 4 are not needed for m48t59 QOM'ification, but are in my
> opinion a nice cleanup.
> 
> Hervé Poussineau (4):
>   m48t59: move ISA ports/memory regions registration to QOM constructor
>   m48t59: register a QOM type for each nvram type we support
>   m48t59: add a Nvram interface
>   m48t59: let init functions return a Nvram object
> 
>  hw/ppc/ppc.c              |  161 ----------------------
>  hw/ppc/prep.c             |  161 ++++++++++++++++++++--
>  hw/sparc/sun4m.c          |    8 +-
>  hw/sparc64/sun4u.c        |   10 +-
>  hw/timer/m48t59.c         |  336 ++++++++++++++++++++++++++++++++-------------
>  include/hw/timer/m48t59.h |   60 ++++----
>  6 files changed, 429 insertions(+), 307 deletions(-)

I've tested this in conjunction with a rebased version of my sun4u NVRAM
changes for SPARC32 and SPARC64 and it looks good so:

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

I'll post a new version of my sun4u NVRAM changes rebased on your two
patchsets shortly.


ATB,

Mark.