All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] automake: complete the removal of the target package
Date: Sun, 01 Feb 2015 22:51:17 +0100	[thread overview]
Message-ID: <54CE9FD5.2070507@openwide.fr> (raw)
In-Reply-To: <1422809500-23948-1-git-send-email-fabio.porcedda@gmail.com>

Hi Fabio,

Le 01/02/2015 17:51, Fabio Porcedda a ?crit :
> The variable ACLOCAL_DIR points to the staging area but is not useful
> anymore because the target package was removed.  Fix ACLOCAL_DIR by
> pointing to $(HOST_DIR)/usr/share/aclocal and remove ACLOCAL_HOST_DIR
> because ACLOCAL_DIR has the same value so it's not useful anymore.
> 
> Also remove the reference to ACLOCAL_HOST_DIR from the host-autoconf
> package.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  package/autoconf/autoconf.mk | 2 +-
>  package/automake/automake.mk | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/autoconf/autoconf.mk b/package/autoconf/autoconf.mk
> index fd91961..2c0ff30 100644
> --- a/package/autoconf/autoconf.mk
> +++ b/package/autoconf/autoconf.mk
> @@ -23,4 +23,4 @@ $(eval $(host-autotools-package))
>  # variables used by other packages
>  AUTOCONF = $(HOST_DIR)/usr/bin/autoconf
>  AUTOHEADER = $(HOST_DIR)/usr/bin/autoheader
> -AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL="$(ACLOCAL)" AUTOCONF="$(AUTOCONF)" AUTOHEADER="$(AUTOHEADER)" AUTOMAKE="$(AUTOMAKE)" AUTOPOINT=/bin/true $(HOST_DIR)/usr/bin/autoreconf -f -i -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)"
> +AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL="$(ACLOCAL)" AUTOCONF="$(AUTOCONF)" AUTOHEADER="$(AUTOHEADER)" AUTOMAKE="$(AUTOMAKE)" AUTOPOINT=/bin/true $(HOST_DIR)/usr/bin/autoreconf -f -i -I "$(ACLOCAL_DIR)"
> diff --git a/package/automake/automake.mk b/package/automake/automake.mk
> index a3fd18c..5021b49 100644
> --- a/package/automake/automake.mk
> +++ b/package/automake/automake.mk
> @@ -28,6 +28,5 @@ $(eval $(host-autotools-package))
>  
>  # variables used by other packages
>  AUTOMAKE = $(HOST_DIR)/usr/bin/automake
> -ACLOCAL_DIR = $(STAGING_DIR)/usr/share/aclocal
> -ACLOCAL_HOST_DIR = $(HOST_DIR)/usr/share/aclocal
> +ACLOCAL_DIR = $(HOST_DIR)/usr/share/aclocal
>  ACLOCAL = $(HOST_DIR)/usr/bin/aclocal -I $(ACLOCAL_DIR)
> 

Reviewed-by: Romain Naour <romain.naour@openwide.fr>

Best regards,
Romain Naour

  parent reply	other threads:[~2015-02-01 21:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-01 16:51 [Buildroot] [PATCH 1/2] automake: complete the removal of the target package Fabio Porcedda
2015-02-01 16:51 ` [Buildroot] [PATCH 2/2] automake: use whenever possible the ACLOCAL_DIR variable Fabio Porcedda
2015-02-01 21:52   ` Romain Naour
2015-02-02 23:02   ` Peter Korsgaard
2015-02-08 10:48     ` Fabio Porcedda
2015-02-01 21:51 ` Romain Naour [this message]
2015-02-02 23:01 ` [Buildroot] [PATCH 1/2] automake: complete the removal of the target package Peter Korsgaard
2015-02-02 23:38   ` Peter Korsgaard
2015-02-08 10:51     ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CE9FD5.2070507@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.