From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Kuankuan <ykk@rock-chips.com>
Subject: Re: [PATCH v2 05/12] drm: rockchip/vop: filter interlace display
 mode
Date: Mon, 02 Feb 2015 03:28:16 -0500
Message-ID: <54CF3520.7080301@rock-chips.com>
References: <1422617031-25098-1-git-send-email-ykk@rock-chips.com> <1422617388-25476-1-git-send-email-ykk@rock-chips.com> <CAGS+omBtWPqfsLoOJd6uZrGpx8soE4ezx_TYNu4qwy6tTsMyHA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAGS+omBtWPqfsLoOJd6uZrGpx8soE4ezx_TYNu4qwy6tTsMyHA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: David Airlie <airlied@linux.ie>, Russell King <rmk+kernel@arm.linux.org.uk>, Philipp Zabel <p.zabel@pengutronix.de>, Fabio Estevam <fabio.estevam@freescale.com>, Shawn Guo <shawn.guo@linaro.org>, Rob Clark <robdclark@gmail.com>, Mark Yao <mark.yao@rock-chips.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dbehr@chromoum.org, =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= <mmind00@googlemail.com>, Douglas Anderson <dianders@chromium.org>, =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= <marcheu@chromium.org>, rockchip-discuss <rockchip-discuss@chromium.org>
List-Id: dri-devel@lists.freedesktop.org


On 02/02/2015 03:00 AM, Daniel Kurtz wrote:
> Hi ykk,
>
> On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang <ykk@rock-chips.com> wrote:
>> RK3288's VOP do not support INTERLACE display mode, so we should
>> remove those modes out of mode_ok list.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> Can you move this patch out of your hdmi audio patch set, and send it
> separately?
> This fix is independent of the others.
>
> Thanks!
>

Okay. : )

>> ---
>> Changes in v2:
>> - filter interlace display mode for rockchip vop
>>
>>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> index 9a5c571..bedab42 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
>>                                  const struct drm_display_mode *mode,
>>                                  struct drm_display_mode *adjusted_mode)
>>   {
>> -       if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
>> +       if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 ||
>> +           (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE))
>>                  return false;
>>
>>          return true;
>> --
>> 2.1.2
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "rockchip-discuss" group.
>> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/rockchip-discuss/1422617388-25476-1-git-send-email-ykk%40rock-chips.com.
>>
>> To unsubscribe from this group and stop receiving emails from it, send an email to rockchip-discuss+unsubscribe@chromium.org.
>
>