From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re:
 =?utf-8?q?=5BPATCH_v2_1/5=5D_x86/shadow=3A_tidy_up_fr?=
 =?utf-8?q?agmentary_page_lists_in_multi=E2=80=91page_shadows?=
Date: Mon, 2 Feb 2015 11:43:45 +0000
Message-ID: <54CF62F1.1060206@citrix.com>
References: <54CF68DF020000780005BD6C@mail.emea.novell.com>
	<54CF6B24020000780005BD95@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YIFPy-0006et-Gx
	for xen-devel@lists.xenproject.org; Mon, 02 Feb 2015 11:43:50 +0000
In-Reply-To: <54CF6B24020000780005BD95@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 02/02/15 11:18, Jan Beulich wrote:
> From: Tim Deegan <tim@xen.org>
>
> Multi-page shadows are linked together using the 'list' field.  When
> those shadows are in the pinned list, the list fragments are spliced
> into the pinned list; otherwise they have no associated list head.
>
> Rework the code that handles these fragments to use the page_list
> interface rather than manipulating the fields directly.  This makes
> the code cleaner, and allows the 'list' field to be either the
> compact pdx form or a normal list_entry.
>
> Signed-off-by: Tim Deegan <tim@xen.org>

I put v1 of the patch through XenRT over the weekend, and nothing
appeared to blow up spectacularly.

Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> Introduce sh_terminate_list() and make it use LIST_POISON*.
>
> Move helper array of shadow_size() into common.c.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with 1 small comment

>
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -1196,6 +1196,26 @@ int shadow_cmpxchg_guest_entry(struct vc
>   * the free pool.
>   */
>  
> +const u32 sh_type_to_size[] = {

u8 instead?  The maximum value held is 4.

~Andrew