Re: [PATCH v2 2/5] x86/shadow: don't needlessly expose internal functions

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 02/02/15 11:19, Jan Beulich wrote:
> ... and drop an unused one.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -2383,7 +2383,7 @@ int sh_remove_write_access_from_sl1p(str
>  /* Remove all mappings of a guest frame from the shadow tables.
>   * Returns non-zero if we need to flush TLBs. */
>  
> -int sh_remove_all_mappings(struct vcpu *v, mfn_t gmfn)
> +static int sh_remove_all_mappings(struct vcpu *v, mfn_t gmfn)
>  {
>      struct page_info *page = mfn_to_page(gmfn);
>  
> --- a/xen/arch/x86/mm/shadow/private.h
> +++ b/xen/arch/x86/mm/shadow/private.h
> @@ -387,6 +387,11 @@ int shadow_write_guest_entry(struct vcpu
>  int shadow_cmpxchg_guest_entry(struct vcpu *v, intpte_t *p,
>                                 intpte_t *old, intpte_t new, mfn_t gmfn);
>  
> +/* Update all the things that are derived from the guest's CR0/CR3/CR4.
> + * Called to initialize paging structures if the paging mode
> + * has changed, and when bringing up a VCPU for the first time. */
> +void shadow_update_paging_modes(struct vcpu *v);
> +
>  /* Unhook the non-Xen mappings in this top-level shadow mfn.
>   * With user_only == 1, unhooks only the user-mode mappings. */
>  void shadow_unhook_mappings(struct vcpu *v, mfn_t smfn, int user_only);
> --- a/xen/include/asm-x86/shadow.h
> +++ b/xen/include/asm-x86/shadow.h
> @@ -77,23 +77,6 @@ void shadow_teardown(struct domain *d);
>  /* Call once all of the references to the domain have gone away */
>  void shadow_final_teardown(struct domain *d);
>  
> -/* Update all the things that are derived from the guest's CR0/CR3/CR4.
> - * Called to initialize paging structures if the paging mode
> - * has changed, and when bringing up a VCPU for the first time. */
> -void shadow_update_paging_modes(struct vcpu *v);
> -
> -
> -/* Remove all mappings of the guest page from the shadows. 
> - * This is called from common code.  It does not flush TLBs. */
> -int sh_remove_all_mappings(struct vcpu *v, mfn_t target_mfn);
> -static inline void 
> -shadow_drop_references(struct domain *d, struct page_info *p)
> -{
> -    if ( unlikely(shadow_mode_enabled(d)) )
> -        /* See the comment about locking in sh_remove_all_mappings */
> -        sh_remove_all_mappings(d->vcpu[0], _mfn(page_to_mfn(p)));
> -}
> -
>  /* Remove all shadows of the guest mfn. */
>  void sh_remove_shadows(struct vcpu *v, mfn_t gmfn, int fast, int all);
>  static inline void shadow_remove_all_shadows(struct vcpu *v, mfn_t gmfn)
>
>
>