All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: vino: vino: Removed variables that is never used
Date: Mon, 02 Feb 2015 14:21:15 +0100	[thread overview]
Message-ID: <54CF79CB.6000603@xs4all.nl> (raw)
In-Reply-To: <1422485265-11231-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 01/28/2015 11:47 PM, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
> 
> This was found using a static code analysis program called cppcheck

FYI: I've dropped this patch since the vino driver will be removed in 3.20.

Regards.

	Hans

> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  drivers/staging/media/vino/vino.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/vino/vino.c b/drivers/staging/media/vino/vino.c
> index 2c85357..f43c1ea 100644
> --- a/drivers/staging/media/vino/vino.c
> +++ b/drivers/staging/media/vino/vino.c
> @@ -2375,7 +2375,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id)
>  		next_4_desc = vino->a.next_4_desc;
>  	unsigned int line_count_2,
>  		page_index_2,
> -		field_counter_2,
>  		start_desc_tbl_2,
>  		next_4_desc_2;
>  #endif
> @@ -2421,7 +2420,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id)
>  #ifdef VINO_DEBUG_INT
>  			line_count_2 = vino->a.line_count;
>  			page_index_2 = vino->a.page_index;
> -			field_counter_2 = vino->a.field_counter;
>  			start_desc_tbl_2 = vino->a.start_desc_tbl;
>  			next_4_desc_2 = vino->a.next_4_desc;
>  
> 


      reply	other threads:[~2015-02-02 13:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 22:47 [PATCH] staging: media: vino: vino: Removed variables that is never used Rickard Strandqvist
2015-02-02 13:21 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CF79CB.6000603@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans.verkuil@cisco.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.