From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 03/14] ALSA: Add a helper to initialize device Date: Mon, 02 Feb 2015 14:43:02 +0100 Message-ID: <54CF7EE6.6080601@metafoo.de> References: <1422872678-4815-1-git-send-email-tiwai@suse.de> <1422872678-4815-4-git-send-email-tiwai@suse.de> <54CF7C3C.6020100@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-232.synserver.de (smtp-out-232.synserver.de [212.40.185.232]) by alsa0.perex.cz (Postfix) with ESMTP id C293A2605AA for ; Mon, 2 Feb 2015 14:43:01 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 02/02/2015 02:40 PM, Takashi Iwai wrote: [...] >> And on the long run things >> should probably be re-factored to do all memory freeing in a subdevice >> specific release function. > > This patchset is one step toward the simplification, indeed. > > But, what do you have in mind when you write "a subsystem specific > release function"? "subdev specific". What you already do for e.g. hwdep and MIDI, but for all of the subdevice types, so the empty default function is no longer needed. The kfree(container_of(...)) stuff. - Lars