From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH 3/5] hvmemul_do_io: If the send to the ioreq server failed do not retry. Date: Mon, 02 Feb 2015 08:54:33 -0500 Message-ID: <54CF8199.2050209@terremark.com> References: <1422579150-6970-1-git-send-email-dslutz@verizon.com> <1422579150-6970-4-git-send-email-dslutz@verizon.com> <54CB69C7020000780005B2D0@mail.emea.novell.com> <54CBCAD4.2090106@terremark.com> <54CBD93E.3060005@terremark.com> <9AAE0902D5BC7E449B7C8E4E778ABCD0257DEB3D@AMSPEX01CL01.citrite.net> <54CF59A7020000780005BCE0@mail.emea.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD0257DEB64@AMSPEX01CL01.citrite.net> <54CF5C23020000780005BCFE@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54CF5C23020000780005BCFE@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Paul Durrant Cc: Wei Liu , Ian Campbell , Andrew Cooper , George Dunlap , Don Slutz , "xen-devel@lists.xen.org" , Stefano Stabellini , IanJackson , "Keir (Xen.org)" List-Id: xen-devel@lists.xenproject.org On 02/02/15 05:14, Jan Beulich wrote: >>>> On 02.02.15 at 11:06, wrote: >>> -----Original Message----- >>> From: Jan Beulich [mailto:JBeulich@suse.com] >>> Sent: 02 February 2015 10:04 >>> To: Paul Durrant; Don Slutz >>> Cc: Andrew Cooper; George Dunlap; Ian Campbell; Ian Jackson; Stefano >>> Stabellini; Wei Liu; xen-devel@lists.xen.org; Keir (Xen.org) >>> Subject: RE: [PATCH 3/5] hvmemul_do_io: If the send to the ioreq server >>> failed do not retry. >>> >>>>>> On 02.02.15 at 10:51, wrote: >>>>> From: Don Slutz [mailto:dslutz@verizon.com] >>>>> --- a/xen/arch/x86/hvm/hvm.c >>>>> +++ b/xen/arch/x86/hvm/hvm.c >>>>> @@ -2507,9 +2507,45 @@ int hvm_buffered_io_send(ioreq_t *p) >>>>> return 1; >>>>> } >>>>> >>>>> -bool_t hvm_has_dm(struct domain *d) >>>>> +static bool_t hvm_complete_assist_req(ioreq_t *p) >>>> >>>> You'll need to change this to a void return as Jan requested. >>> >>> I don't think I did. >> >> Oh, sorry. I thought you suggested that the constant return of 1 from >> hvm_complete_assist_req() was a bad idea. > > Oh, I see, but that was in another thread, and I really suggested to > remove the function altogether (folding it back into its only caller). > I was planing to also do this. This is why the code was not in patch form. -Don Slutz > Jan >