From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: rcu_sched self-detect stall when disable vif device Date: Mon, 02 Feb 2015 13:54:52 +0000 Message-ID: <54CF81AC.1070400@linaro.org> References: <54C7B6E8.9080106@linaro.org> <20150127164539.GJ24026@zion.uk.xensource.com> <54C7C131.9030502@linaro.org> <20150127165312.GK24026@zion.uk.xensource.com> <54C91229.8090104@linaro.org> <54C91712.3020806@citrix.com> <54C91C15.7030709@linaro.org> <54CBAB75.1080301@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54CBAB75.1080301@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Wei Liu Cc: Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org Hi David, On 30/01/15 16:04, David Vrabel wrote: > How about this? This is working for me. Thanks! > 8<------------------------------------------ > xen-netback: stop the guest rx thread after a fatal error > > After commit e9d8b2c2968499c1f96563e6522c56958d5a1d0d (xen-netback: > disable rogue vif in kthread context), a fatal (protocol) error would > leave the guest Rx thread spinning, wasting CPU time. Commit > ecf08d2dbb96d5a4b4bcc53a39e8d29cc8fef02e (xen-netback: reintroduce > guest Rx stall detection) made this even worse by removing a > cond_resched() from this path. > > A fatal error is non-recoverable so just allow the guest Rx thread to > exit. This requires taking additional refs to the task so the thread > exiting early is handled safely. > > Signed-off-by: David Vrabel Reported-by: Julien Grall Tested-by: Julien Grall Regards, -- Julien Grall