From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932522AbbBBQOW (ORCPT ); Mon, 2 Feb 2015 11:14:22 -0500 Received: from mga14.intel.com ([192.55.52.115]:50896 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122AbbBBQOU (ORCPT ); Mon, 2 Feb 2015 11:14:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,507,1418112000"; d="scan'208";a="521375597" Message-ID: <54CFA256.5010106@linux.intel.com> Date: Tue, 03 Feb 2015 00:14:14 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ricardo Ribalda Delgado , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, David Vrabel , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/devicetree: Fix build for amd64 References: <1422892230-28328-1-git-send-email-ricardo.ribalda@gmail.com> In-Reply-To: <1422892230-28328-1-git-send-email-ricardo.ribalda@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, How about defining a version of apic_force_enable() for X86_64 in apic.h which just return failure? Regards! Gerry On 2015/2/2 23:50, Ricardo Ribalda Delgado wrote: > apic_force_enable is not defined for amd64. > > Without this patch: > > LD init/built-in.o > arch/x86/built-in.o: In function `dtb_lapic_setup': > kernel/devicetree.c:155: > undefined reference to `apic_force_enable' > Makefile:923: recipe for target 'vmlinux' failed > make: *** [vmlinux] Error 1 > > Signed-off-by: Ricardo Ribalda Delgado > --- > arch/x86/kernel/devicetree.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c > index 3d35033..b5560de 100644 > --- a/arch/x86/kernel/devicetree.c > +++ b/arch/x86/kernel/devicetree.c > @@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void) > > /* Did the boot loader setup the local APIC ? */ > if (!cpu_has_apic) { > +#ifndef CONFIG_X86_64 > if (apic_force_enable(r.start)) > +#endif > return; > } > smp_found_config = 1; >