From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page
Date: Mon, 02 Feb 2015 17:47:49 +0100 [thread overview]
Message-ID: <54CFAA35.4030805@redhat.com> (raw)
In-Reply-To: <1422895464-18038-2-git-send-email-den@openvz.org>
On 02/02/2015 17:44, Denis V. Lunev wrote:
> +++ b/block/raw-posix.c
> @@ -667,7 +667,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
> BDRVRawState *s = bs->opaque;
>
> raw_probe_alignment(bs, s->fd, errp);
> - bs->bl.opt_mem_alignment = s->buf_align;
> + bs->bl.min_mem_alignment = s->buf_align;
> + bs->bl.opt_mem_alignment = MAX(sysconf(_SC_PAGESIZE), s->buf_align);
This does not exist on Windows. You have to use getpagesize(), for
which there is a wrapper in util/oslib-win32.c.
Paolo
> raw_probe_max_write_zeroes(bs);
next prev parent reply other threads:[~2015-02-02 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 16:44 [Qemu-devel] [PATCH v3 0/1] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-02-02 16:44 ` [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page Denis V. Lunev
2015-02-02 16:47 ` Paolo Bonzini [this message]
2015-02-02 16:49 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CFAA35.4030805@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.