From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] alsa-lib: Force arm mode instead of Thumb1 mode
Date: Mon, 02 Feb 2015 18:32:59 +0100 [thread overview]
Message-ID: <54CFB4CB.1070007@mind.be> (raw)
In-Reply-To: <54CFB1E2.4010809@mind.be>
On 02/02/15 18:20, Arnout Vandecappelle wrote:
> On 20/01/15 12:24, Richard Genoud wrote:
>> alsa-lib has some assembly that doesn't exist in thumb1 mode.
>> So, force arm mode for alsa-lib.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> However, I can't find the assembly that you refer to. And of course
> this problem only becomes apparent at runtime.
Actually, it should lead to a build failure. So I really don't see
why this patch would be needed.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2015-02-02 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 11:24 [Buildroot] [PATCH 1/3] dmalloc: Force arm mode instead of Thumb1 mode Richard Genoud
2015-01-20 11:24 ` [Buildroot] [PATCH 2/3] alsa-lib: " Richard Genoud
2015-02-02 17:20 ` Arnout Vandecappelle
2015-02-02 17:29 ` Peter Korsgaard
2015-02-02 17:32 ` Arnout Vandecappelle [this message]
2015-01-20 11:24 ` [Buildroot] [PATCH 3/3] qt: " Richard Genoud
2015-02-02 17:35 ` Arnout Vandecappelle
2015-02-02 20:42 ` Peter Korsgaard
2015-01-25 19:31 ` [Buildroot] [PATCH 1/3] dmalloc: " Thomas Petazzoni
2015-01-26 11:07 ` Richard Genoud
2015-01-26 11:20 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CFB4CB.1070007@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.