From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YIMop-00015c-G0 for linux-mtd@lists.infradead.org; Mon, 02 Feb 2015 19:38:07 +0000 Message-ID: <54CFD1FB.5030208@nod.at> Date: Mon, 02 Feb 2015 20:37:31 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Ricardo Ribalda Delgado , Richard Weinberger Subject: Re: [PATCH] mtd: Expose partition offset to the drivers References: <1422894152-29362-1-git-send-email-ricardo.ribalda@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , LKML List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi! Am 02.02.2015 um 20:33 schrieb Ricardo Ribalda Delgado: > Hello > > On Mon, Feb 2, 2015 at 8:17 PM, Richard Weinberger > wrote: >> On Mon, Feb 2, 2015 at 5:22 PM, Ricardo Ribalda Delgado >> >> Can you please also send a patch which shows the usage of this new function >> by a driver? > > It is currently out of tree, but here you can see the relevant code: > > mtd_offset=mtd_get_device_offset(mtd); > put_mtd_device(mtd); > if (do_jmp){ > ret=qt5023_hwicap_reset(head,mtd_offset); > if (ret){ > dev_err(&head->pci_dev->dev,"error: Failed to jump to new bitfile\n"); > vfree(buffer); > release_firmware(firmware); > return -EIO; > } > qt5023_spi_restart(head); > } Hmm, will we ever need the new function for in-tree drivers? In general we add new functions only if they have an in-tree user for it. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965058AbbBBThj (ORCPT ); Mon, 2 Feb 2015 14:37:39 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965032AbbBBThf (ORCPT ); Mon, 2 Feb 2015 14:37:35 -0500 Message-ID: <54CFD1FB.5030208@nod.at> Date: Mon, 02 Feb 2015 20:37:31 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ricardo Ribalda Delgado , Richard Weinberger CC: David Woodhouse , Brian Norris , "linux-mtd@lists.infradead.org" , LKML Subject: Re: [PATCH] mtd: Expose partition offset to the drivers References: <1422894152-29362-1-git-send-email-ricardo.ribalda@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Am 02.02.2015 um 20:33 schrieb Ricardo Ribalda Delgado: > Hello > > On Mon, Feb 2, 2015 at 8:17 PM, Richard Weinberger > wrote: >> On Mon, Feb 2, 2015 at 5:22 PM, Ricardo Ribalda Delgado >> >> Can you please also send a patch which shows the usage of this new function >> by a driver? > > It is currently out of tree, but here you can see the relevant code: > > mtd_offset=mtd_get_device_offset(mtd); > put_mtd_device(mtd); > if (do_jmp){ > ret=qt5023_hwicap_reset(head,mtd_offset); > if (ret){ > dev_err(&head->pci_dev->dev,"error: Failed to jump to new bitfile\n"); > vfree(buffer); > release_firmware(firmware); > return -EIO; > } > qt5023_spi_restart(head); > } Hmm, will we ever need the new function for in-tree drivers? In general we add new functions only if they have an in-tree user for it. Thanks, //richard