Hi Denis, > Hi Tomasz, > > On 01/30/2015 04:57 AM, Tomasz Bursztyka wrote: >> Hi, >> >> Went quickly through the cipher proposal, to get a somehow working >> implementation. >> Seems to work with aes, but not with arc4. >> > > ARC4 is a bit weird. The same function is used for encryption and > decryption, so the stream is not reset. You will likely need to set > the key prior to each encrypt/decrypt operation. OK. > >> And now I wonder if we should not provide an initialization vector >> for some ciphers? (like arc4). >> > > I'm still not fully sure we need the IV. EAPoL Key-IV is only used in > certain situations. Lets try to find an AP / trace that actually sets > the IV field. > Ok, then I think it's worth putting an iv/iv-len params to the l_cipher_new(). I might implement its support later though, let's see (but at least the API would be fixed). Tomasz