From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZDq-0005aL-TC for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:52:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIZDn-0006KU-NH for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:52:38 -0500 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:60125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZDn-0006KL-G2 for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:52:35 -0500 Received: by mail-wg0-f47.google.com with SMTP id n12so43307622wgh.6 for ; Tue, 03 Feb 2015 00:52:34 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54D08C4F.5050705@redhat.com> Date: Tue, 03 Feb 2015 09:52:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> <1422643333-27926-14-git-send-email-jsnow@redhat.com> <54CF52EF.7090805@redhat.com> <54CFE7A2.2090304@redhat.com> In-Reply-To: <54CFE7A2.2090304@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org On 02/02/2015 22:09, John Snow wrote: > > In this case, only the command header had a utility written for it to > flip the bits for me. This is part of the FIS, instead, which has no > explicit flip-on-write mechanism inside of commit. > > So, it's correct, but not terribly consistent. > > I can write a fis write helper to make this more internally consistent > about when we handle it for the user and when we don't. Please do. :) Paolo