Re: [Qemu-devel] [PATCH 10/15] exec: RCUify AddressSpaceDispatch

[Paolo Bonzini <pbonzini@redhat.com>]

On 28/01/2015 06:45, Fam Zheng wrote:
> If I understand it, this code doesn't hold iothread lock when releasing the
> memory region, but in one of the memroy region destructors,
> memory_region_destructor_ram_from_ptr:
> 
>     void qemu_ram_free_from_ptr(ram_addr_t addr)
>     {
>         RAMBlock *block;
> 
>         /* This assumes the iothread lock is taken here too.  */
>         qemu_mutex_lock_ramlist();
>         QTAILQ_FOREACH(block, &ram_list.blocks, next) {
> ...
> 
> Is the comment stale or I missed something?

No, you're right.

Paolo