From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Tue, 03 Feb 2015 15:35:25 +0100 Subject: [ath9k-devel] [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode In-Reply-To: <87fvanxldu.fsf@kamboji.qca.qualcomm.com> References: <1422957585-19736-1-git-send-email-yuweizheng@139.com> <87fvanxldu.fsf@kamboji.qca.qualcomm.com> Message-ID: <54D0DCAD.8060409@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org It seems to work without noticeable regressions. Am 03.02.2015 um 12:52 schrieb Kalle Valo: > yuweizheng at 139.com writes: > >> From: Yuwei Zheng >> >> In the environment with heavy wifi traffic, set the ar9271 into monitor mode, will >> trigger a deadloop panic. >> >> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and ath9k_rx_tasklet excute >> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than >> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive list is always full, >> and the do {}while(true) loop will not be break. The kernel get a soft lockup panic. > > The word wrapping is still wrong, please limit the width to 72 chars or > so. But no need to wrap log snippets, they can exceed the limit. > >> Signed-off-by: Yuwei Zheng >> Signed-off-by: Yuwei Zheng > > Why two of these? Please use just one Signed-off-by line. Unless these > are two different persons with the same name :) > -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20150203/698d37d2/attachment.pgp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.17.21]:64207 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755932AbbBCOf6 (ORCPT ); Tue, 3 Feb 2015 09:35:58 -0500 Message-ID: <54D0DCAD.8060409@rempel-privat.de> (sfid-20150203_153601_485059_B2E20888) Date: Tue, 03 Feb 2015 15:35:25 +0100 From: Oleksij Rempel MIME-Version: 1.0 To: Kalle Valo , yuweizheng@139.com CC: linux-kernel@vger.kernel.org, ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com, netdev@vger.kernel.org, Yuwei Zheng Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode References: <1422957585-19736-1-git-send-email-yuweizheng@139.com> <87fvanxldu.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87fvanxldu.fsf@kamboji.qca.qualcomm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj" Sender: linux-wireless-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It seems to work without noticeable regressions. Am 03.02.2015 um 12:52 schrieb Kalle Valo: > yuweizheng@139.com writes: >=20 >> From: Yuwei Zheng >> >> In the environment with heavy wifi traffic, set the ar9271 into monito= r mode, will >> trigger a deadloop panic. >> =20 >> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and= ath9k_rx_tasklet excute >> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have = more chance to excute than >> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive li= st is always full, >> and the do {}while(true) loop will not be break. The kernel get a soft= lockup panic.=20 >=20 > The word wrapping is still wrong, please limit the width to 72 chars or= > so. But no need to wrap log snippets, they can exceed the limit. >=20 >> Signed-off-by: Yuwei Zheng >> Signed-off-by: Yuwei Zheng >=20 > Why two of these? Please use just one Signed-off-by line. Unless these > are two different persons with the same name :) >=20 --=20 Regards, Oleksij --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREIAAYFAlTQ3LIACgkQHwImuRkmbWlnBQD/UqYjFgmRJJN5eTPDzTkqtBgh 1jOz1JyQN7UA3qOVSlwA/3fcKEeAExwgxbBjrCwv4YGxCffxeAYgPh8v1r6ICL// =8qX6 -----END PGP SIGNATURE----- --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965680AbbBCOgB (ORCPT ); Tue, 3 Feb 2015 09:36:01 -0500 Received: from mout.gmx.net ([212.227.17.21]:64207 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755932AbbBCOf6 (ORCPT ); Tue, 3 Feb 2015 09:35:58 -0500 Message-ID: <54D0DCAD.8060409@rempel-privat.de> Date: Tue, 03 Feb 2015 15:35:25 +0100 From: Oleksij Rempel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kalle Valo , yuweizheng@139.com CC: linux-kernel@vger.kernel.org, ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com, netdev@vger.kernel.org, Yuwei Zheng Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode References: <1422957585-19736-1-git-send-email-yuweizheng@139.com> <87fvanxldu.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87fvanxldu.fsf@kamboji.qca.qualcomm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj" X-Provags-ID: V03:K0:IKVy9NrGIGJE2QndqxXkQVQfr9cOvP63BJgZqNhBRegL3dzq4jT G4+hEJgnbPZfJplZNSyYqf4mnq59SyISba8s7IEgiwOU6ndqntGgZL+aNepCxwVszRtQosW 5Au5npLsnqeL71z0KuzQnQp8Kx+rFqZ9zLl5U1kqsG4pYXEVBFStrVrKDctKZSZlhNZj69L vD1G8hciCHBqXk40gC10w== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It seems to work without noticeable regressions. Am 03.02.2015 um 12:52 schrieb Kalle Valo: > yuweizheng@139.com writes: >=20 >> From: Yuwei Zheng >> >> In the environment with heavy wifi traffic, set the ar9271 into monito= r mode, will >> trigger a deadloop panic. >> =20 >> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and= ath9k_rx_tasklet excute >> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have = more chance to excute than >> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive li= st is always full, >> and the do {}while(true) loop will not be break. The kernel get a soft= lockup panic.=20 >=20 > The word wrapping is still wrong, please limit the width to 72 chars or= > so. But no need to wrap log snippets, they can exceed the limit. >=20 >> Signed-off-by: Yuwei Zheng >> Signed-off-by: Yuwei Zheng >=20 > Why two of these? Please use just one Signed-off-by line. Unless these > are two different persons with the same name :) >=20 --=20 Regards, Oleksij --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREIAAYFAlTQ3LIACgkQHwImuRkmbWlnBQD/UqYjFgmRJJN5eTPDzTkqtBgh 1jOz1JyQN7UA3qOVSlwA/3fcKEeAExwgxbBjrCwv4YGxCffxeAYgPh8v1r6ICL// =8qX6 -----END PGP SIGNATURE----- --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode Date: Tue, 03 Feb 2015 15:35:25 +0100 Message-ID: <54D0DCAD.8060409@rempel-privat.de> References: <1422957585-19736-1-git-send-email-yuweizheng@139.com> <87fvanxldu.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yuwei Zheng To: Kalle Valo , yuweizheng-7R9yAhoRP9E@public.gmane.org Return-path: In-Reply-To: <87fvanxldu.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It seems to work without noticeable regressions. Am 03.02.2015 um 12:52 schrieb Kalle Valo: > yuweizheng-7R9yAhoRP9E@public.gmane.org writes: >=20 >> From: Yuwei Zheng >> >> In the environment with heavy wifi traffic, set the ar9271 into monito= r mode, will >> trigger a deadloop panic. >> =20 >> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and= ath9k_rx_tasklet excute >> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have = more chance to excute than >> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive li= st is always full, >> and the do {}while(true) loop will not be break. The kernel get a soft= lockup panic.=20 >=20 > The word wrapping is still wrong, please limit the width to 72 chars or= > so. But no need to wrap log snippets, they can exceed the limit. >=20 >> Signed-off-by: Yuwei Zheng >> Signed-off-by: Yuwei Zheng >=20 > Why two of these? Please use just one Signed-off-by line. Unless these > are two different persons with the same name :) >=20 --=20 Regards, Oleksij --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREIAAYFAlTQ3LIACgkQHwImuRkmbWlnBQD/UqYjFgmRJJN5eTPDzTkqtBgh 1jOz1JyQN7UA3qOVSlwA/3fcKEeAExwgxbBjrCwv4YGxCffxeAYgPh8v1r6ICL// =8qX6 -----END PGP SIGNATURE----- --iUpB7LPx2HInfLWVkAtsumNpumKIEm6uj-- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html