All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	Troy Tan <troy_tan@realsil.com.cn>,
	netdev@vger.kernel.org, Stable <stable@vger.kernel.org>
Subject: Re: [V2,for,3.19,3/7] rtlwifi: rtl8192ee: Fix adhoc fail
Date: Tue, 03 Feb 2015 10:00:45 -0600	[thread overview]
Message-ID: <54D0F0AD.7070209@lwfinger.net> (raw)
In-Reply-To: <87r3u7w2l5.fsf@kamboji.qca.qualcomm.com>

On 02/03/2015 07:23 AM, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>>> From: Troy Tan <troy_tan@realsil.com.cn>
>>>
>>> When the buffer descriptor index exceeds 2, then a TX HANG condition
>>> will result.
>>>
>>> Signed-off-by: Troy Tan <troy_tan@realsil.com.cn>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> Cc: Stable <stable@vger.kernel.org> [V3.18]
>>
>> Thanks, 4 patches applied to wireless-drivers-next.git:
>>
>> b661a5da5776 rtlwifi: rtl8192ee: Fix adhoc fail
>> 6e5f44361628 rtlwifi: rtl8192ee: Fix TX hang due to failure to update TX write point
>> 92ff754240b8 rtlwifi: rtl8192ee: Fix parsing of received packet
>> 21b39ddb5bb2 rtlwifi: rtl8192ee: Fix DMA stalls
>>
>> 3 patches skipped:
>
> I had to skip these three patches because of my mistake. So what I did
> was that I had merged ("fast forwarded") the net tree into my
> wireless-drivers tree and not realising I should not do that. So now I
> can't merge wireless-drivers into wireless-drivers-next anymore, as it
> will pull unnecessary net changes.
>
>> [V2,for,3.19,1/7] rtlwifi: Remove logging statement that is no longer
>> needed
>
> I'll apply this after 3.20-rc1 is released, it should apply then without
> problems (or the conflicts are easy for me to fix). Luckily this is just
> a cosmetic error and can wait for 3.20-rc2, right?

That is correct. 3.20-rc2 will be OK. I'll probably get a bunch of "your **** 
driver is spamming my logs, but I can ignore them".

>
>> [V2,for,3.19,2/7] rtlwifi: rtl8192ee: Fix handling of new style descriptors
>> [V2,for,3.19,6/7] rtlwifi: rtl8192ee: Fix problems with calculating free space in FIFO
>
> Not sure what to do with these one. Should you rebase and send them now?

These two fix real bugs and need to be in the kernel ASAP. Unfortunately, I saw 
you pass them off to DaveM and I deleted them from my "Submitted Patch" list. I 
can recreate them from my working copy of wireless-drivers, and I will resubmit. 
When I do, please process them as quickly as possible.

Thanks,

Larry




  reply	other threads:[~2015-02-03 16:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 17:01 [PATCH V2 for 3.19 0/7] Fixes for rtl8192ee Larry Finger
2015-01-20 17:01 ` Larry Finger
2015-01-20 17:01 ` [PATCH V2 for 3.19 1/7] rtlwifi: Remove logging statement that is no longer needed Larry Finger
2015-01-20 17:01   ` Larry Finger
2015-02-10 14:10   ` [V2, for, 3.19, " Kalle Valo
2015-01-20 17:01 ` [PATCH V2 for 3.19 2/7] rtlwifi: rtl8192ee: Fix handling of new style descriptors Larry Finger
2015-01-20 17:01 ` [PATCH V2 for 3.19 3/7] rtlwifi: rtl8192ee: Fix adhoc fail Larry Finger
2015-01-20 17:01   ` Larry Finger
2015-02-03 13:15   ` [V2,for,3.19,3/7] " Kalle Valo
2015-02-03 13:23     ` Kalle Valo
2015-02-03 16:00       ` Larry Finger [this message]
2015-01-20 17:01 ` [PATCH V2 for 3.19 4/7] rtlwifi: rtl8192ee: Fix TX hang due to failure to update TX write point Larry Finger
2015-01-20 17:01   ` Larry Finger
2015-01-20 17:01 ` [PATCH V2 for 3.19 5/7] rtlwifi: rtl8192ee: Fix parsing of received packet Larry Finger
2015-01-20 17:01 ` [PATCH V2 for 3.19 6/7] rtlwifi: rtl8192ee: Fix problems with calculating free space in FIFO Larry Finger
2015-01-20 17:01 ` [PATCH V2 for 3.19 7/7] rtlwifi: rtl8192ee: Fix DMA stalls Larry Finger
2015-01-23 15:26 ` [PATCH V2 for 3.19 0/7] Fixes for rtl8192ee Kalle Valo
2015-01-23 16:40   ` Larry Finger
2015-01-23 20:24     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D0F0AD.7070209@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=troy_tan@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.