From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/2] hvmloader: remove timestamp from vgabios Date: Tue, 3 Feb 2015 16:06:26 +0000 Message-ID: <54D0F202.2070209@citrix.com> References: <1422978845-5908-1-git-send-email-olaf@aepfle.de> <1422978845-5908-3-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422978845-5908-3-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering , xen-devel@lists.xen.org Cc: Ian Jackson , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 03/02/15 15:54, Olaf Hering wrote: > Including a timestamp into the binary makes it impossible to get > reproducible binaries. Remove the timestamp because it carries no > valuable info. > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu In this case, it would appear that the vgabios_date symbol is completely unused inside the binary. Good riddance! Reviewed-by: Andrew Cooper > --- > tools/firmware/vgabios/Makefile | 11 ++++------- > tools/firmware/vgabios/vgabios.c | 5 ----- > 2 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/tools/firmware/vgabios/Makefile b/tools/firmware/vgabios/Makefile > index 51d9e6e..0951a8a 100644 > --- a/tools/firmware/vgabios/Makefile > +++ b/tools/firmware/vgabios/Makefile > @@ -5,11 +5,8 @@ BCC = bcc > AS86 = as86 > > RELEASE = `pwd | sed "s-.*/--"` > -RELDATE = `date '+%d %b %Y'` > RELVERS = `pwd | sed "s-.*/--" | sed "s/vgabios//" | sed "s/-//"` > > -VGABIOS_DATE = "-DVGABIOS_DATE=\"$(RELDATE)\"" > - > .PHONY: all > all: bios cirrus-bios > > @@ -40,7 +37,7 @@ release: > tar czvf ../$(RELEASE).tgz --exclude CVS -C .. $(RELEASE)/ > > vgabios.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h vbe.h vbe.c vbetables.h > - $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DVBE $(VGABIOS_DATE) > _vgabios_.c > + $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DVBE > _vgabios_.c > $(BCC) -o vgabios.s -C-c -D__i86__ -S -0 _vgabios_.c > sed -e 's/^\.text//' -e 's/^\.data//' vgabios.s > _vgabios_.s > $(AS86) _vgabios_.s -b vgabios.bin -u -w- -g -0 -j -O -l vgabios.txt > @@ -50,7 +47,7 @@ vgabios.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h vbe.h vbe.c vbe > ls -l VGABIOS-lgpl-latest.bin > > vgabios.debug.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h vbe.h vbe.c vbetables.h > - $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DVBE -DDEBUG $(VGABIOS_DATE) > _vgabios-debug_.c > + $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DVBE -DDEBUG > _vgabios-debug_.c > $(BCC) -o vgabios-debug.s -C-c -D__i86__ -S -0 _vgabios-debug_.c > sed -e 's/^\.text//' -e 's/^\.data//' vgabios-debug.s > _vgabios-debug_.s > $(AS86) _vgabios-debug_.s -b vgabios.debug.bin -u -w- -g -0 -j -O -l vgabios.debug.txt > @@ -60,7 +57,7 @@ vgabios.debug.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h vbe.h vbe > ls -l VGABIOS-lgpl-latest.debug.bin > > vgabios-cirrus.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h clext.c > - $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DCIRRUS -DPCIBIOS $(VGABIOS_DATE) > _vgabios-cirrus_.c > + $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DCIRRUS -DPCIBIOS > _vgabios-cirrus_.c > $(BCC) -o vgabios-cirrus.s -C-c -D__i86__ -S -0 _vgabios-cirrus_.c > sed -e 's/^\.text//' -e 's/^\.data//' vgabios-cirrus.s > _vgabios-cirrus_.s > $(AS86) _vgabios-cirrus_.s -b vgabios-cirrus.bin -u -w- -g -0 -j -O -l vgabios-cirrus.txt > @@ -70,7 +67,7 @@ vgabios-cirrus.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h clext.c > ls -l VGABIOS-lgpl-latest.cirrus.bin > > vgabios-cirrus.debug.bin: biossums vgabios.c vgabios.h vgafonts.h vgatables.h clext.c > - $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DCIRRUS -DCIRRUS_DEBUG -DPCIBIOS $(VGABIOS_DATE) > _vgabios-cirrus-debug_.c > + $(GCC) -E -P vgabios.c $(VGABIOS_VERS) -DCIRRUS -DCIRRUS_DEBUG -DPCIBIOS > _vgabios-cirrus-debug_.c > $(BCC) -o vgabios-cirrus-debug.s -C-c -D__i86__ -S -0 _vgabios-cirrus-debug_.c > sed -e 's/^\.text//' -e 's/^\.data//' vgabios-cirrus-debug.s > _vgabios-cirrus-debug_.s > $(AS86) _vgabios-cirrus-debug_.s -b vgabios-cirrus.debug.bin -u -w- -g -0 -j -O -l vgabios-cirrus.debug.txt > diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c > index a9dbe00..aed3e3a 100644 > --- a/tools/firmware/vgabios/vgabios.c > +++ b/tools/firmware/vgabios/vgabios.c > @@ -175,11 +175,6 @@ vgabios_version: > #endif > .ascii " " > > -vgabios_date: > -.ascii VGABIOS_DATE > -.byte 0x0a,0x0d > -.byte 0x00 > - > vgabios_copyright: > .ascii "(C) 2008 the LGPL VGABios developers Team" > .byte 0x0a,0x0d > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel