From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C2E6CE0076F; Tue, 3 Feb 2015 08:26:00 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.171 listed in list.dnswl.org] Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 7CF9DE005B4 for ; Tue, 3 Feb 2015 08:25:50 -0800 (PST) Received: by mail-wi0-f171.google.com with SMTP id l15so25585019wiw.4 for ; Tue, 03 Feb 2015 08:25:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=HyBOIHRVf3B86RazmdzjMcBC/lvBgi5dfvFlHrqwBB8=; b=iTMTtDnuVkllSr3r9E2M9PnuU0AO2LkVSZsDgKoCLJU9RGQxQbiryoYRB4wwzN2Yx7 qbu+aBSCnjw8Z/RmFrrcvptNaBgVwkO1gPOjV+hkpnCxi3VEHwdNxg/c+5V1uCQwXouQ TQoYuSLa7NOc/o3DdqN2lvhLxylo0nGSti2jkOdW7Q8lYPdeWMsWwH7o7EpAbA/GxgqB pcviOUzjLlenXak9LaNtOOCpKxODa6nmdl/q+2EKfGpJYGW17WGnxzX95GwGdLftj5YS G+KElgdUul4V7uy1/z8vpwPbmT/fCk5zjkhjNXvOoYEtih/mt4vcOZNreONvdTgRUxG8 CruQ== X-Gm-Message-State: ALoCoQmykEj4y37HX3XnCB50Uf/Hp+xTmHCUiB71JrStraHEvEFk5M8kZhosYpU9zaaWiQjs0t3S X-Received: by 10.194.234.40 with SMTP id ub8mr57897293wjc.100.1422980749482; Tue, 03 Feb 2015 08:25:49 -0800 (PST) Received: from [192.168.2.143] ([83.217.123.106]) by mx.google.com with ESMTPSA id yy9sm6017322wjc.20.2015.02.03.08.25.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Feb 2015 08:25:48 -0800 (PST) Message-ID: <54D0F68C.8010300@intel.com> Date: Tue, 03 Feb 2015 16:25:48 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <54CBD238.1010206@intel.com> In-Reply-To: Subject: Re: Review of "all machines" page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 16:26:00 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Progress update michaelw/all-machines On 02/02/15 10:28, Barros Pena, Belen wrote: > Thanks, Michael. > > A couple of comments in line, plus a couple of new things I've been able > to look at thanks to your fixes: > > * the add layer notifications need to match the ones in all other pages. > Currently they say: > > "You have added 2 layers: meta-handheld and its dependencies > meta-initramfs. Go to project configuration" > > We should show the project name instead of the 'go to project > configuration' link, and the name of the layer added should be a link to > the layer details page. You can see how the notifications should look like > by adding a layer from the layer details page using the latest poky/master > branch > > This is the commit that applied the changes > > http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=088c19d6442653c6b > 39003057512d75b6c9508b7 Fixed: a27a66d875c909114ce52875c52f703ddbbe71c5 > * The 2-stage select machine process is not in place either. When I click > the 'select machine' button, I am brought to the project page, the machine > is changed, but I get no notification that the change has been made. > This is something that needs implementation in the project page if it isn't already, I will come back to this for the layerdetails page too. > > On 30/01/2015 19:49, "Michael Wood" wrote: > >> Current work in progress available for testing at poky-contrib >> michaelw/all-machines >> >> (If there's no in-line comment it's an item that's still TODO). >> >> Michael >> >>> >>> * The "Show rows" menu doesn't seem to be working properly. When you >>> load >>> the page, the table always shows 10 rows, independently of the value >>> selected in the "show rows" menu >> Fixed > Yes: it now shows 10 when you load the page, and there are 10 machines > listed per page. But the last selected value doesn't seem to be stored in > the cookie. If I select, for example, 50 rows, then visit a couple of > other pages, then I go back to the all machines page, the value is set > back to 10. Fixed: 34124b4223b4bda0b238db35161a2e6ba20436f0 >>> * The machine file information is not coming in >> Unfortunately we have no information available on the machine file that >> I can find to display > We would need to check how the layer index gathers this information, and > do the same if we can. This sounds like a nice to have, and it might be, > but it is actually a 'very nice' to have. Basically, it is useful to be > able to quickly get to the source files if you need to understand what > they are doing. Can I ask you to have a chat with Paul to see how we can > provide this? Fixed: I talked to Paul, it does look like we can re-construct the link to the conf file, I didn't realise it but this is what the layer index does too and I've added it in 63ceb98ac1b6bc63560665582543394eeff05c2b from some random testing this does seem to work.