From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stanimir Varbanov <svarbanov@mm-sol.com>
Subject: Re: [PATCH V2 2/2] spmi: pmic_arb: add support for hw version 2
Date: Tue, 03 Feb 2015 19:14:56 +0200
Message-ID: <54D10210.5030106@mm-sol.com>
References: <1422665201-25569-1-git-send-email-gavidov@codeaurora.org> <1422665201-25569-3-git-send-email-gavidov@codeaurora.org> <54D09C08.7040106@mm-sol.com> <54D0FE6F.4090709@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <54D0FE6F.4090709@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org
List-Id: linux-arm-msm@vger.kernel.org

On 02/03/2015 06:59 PM, Gilad Avidov wrote:
> Hi Stan,
> 
> Thank you for the review.
> 
> On 2/3/2015 2:59 AM, Stanimir Varbanov wrote:
>> Hi Gilad,
>>
>> Thanks for the patch.
>>
>> On 01/31/2015 02:46 AM, Gilad Avidov wrote:
>>> Qualcomm PMIC Arbiter version-2 changes from version-1 are:
>>>
>>> - Some different register offsets.
>>> - New channel register space, one per PMIC peripheral (ppid).
>>>    All tx traffic uses these channels.
>>> - New observer register space. All rx trafic uses this space.
>>> - Different command format for spmi command registers.
>>>
>>> Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
>>> Acked-by: Sagar Dharia <sdharia@codeaurora.org>
>>> ---
>>>   .../bindings/spmi/qcom,spmi-pmic-arb.txt           |   6 +-
>>>   drivers/spmi/spmi-pmic-arb.c                       | 310
>>> +++++++++++++++++----
>>>   2 files changed, 260 insertions(+), 56 deletions(-)
>>>

<snip>

>>>   +/* v1 offset per ee */
>>> +static u32 pmic_arb_offset_v1(struct spmi_pmic_arb_dev *pa, u8 sid,
>>> u16 addr)
>>> +{
>>> +    return 0x800 + 0x80 * (pa->channel);
>> no braces here and in below ops
> 
> will remove braces above.
> 
> About below:
> Did you mean to remove braces from ops such as:
> 
> (sid << 8) | (addr >> 8)
> and
> (opc << 27) | ((sid & 0xf) << 20) | (addr << 4) | (bc & 0x7)
> 
> ?

no, that's fine.

> 
> In the latter case I think the braces improve readability.

I think so, too.

-- 
regards,
Stan