From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 03 Feb 2015 19:40:19 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:20966 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27025206AbbBCSkRfAOwg (ORCPT ); Tue, 3 Feb 2015 19:40:17 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 527BFADD44647; Tue, 3 Feb 2015 18:40:08 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 3 Feb 2015 18:40:11 +0000 Received: from [192.168.65.146] (192.168.65.146) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 3 Feb 2015 10:40:08 -0800 Message-ID: <54D11608.2070408@imgtec.com> Date: Tue, 3 Feb 2015 10:40:08 -0800 From: Leonid Yegoshin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Guenter Roeck , Ralf Baechle CC: , , "Atsushi Nemoto" , Matthew Wilcox Subject: Re: mips: Re-introduce copy_user_page References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1422681807-28395-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.65.146] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 45638 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Leonid.Yegoshin@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 01/30/2015 09:23 PM, Guenter Roeck wrote: > Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced > the inline function copy_user_page for mips with an external reference, > but neglected to introduce the actual non-inline function. Restore it. > > Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") > Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") > Cc: Atsushi Nemoto > Cc: Matthew Wilcox > Signed-off-by: Guenter Roeck > Why do you use copy_user_page? It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. You should use copy_user_highpage() for user pages. - Leonid. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:20966 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27025206AbbBCSkRfAOwg (ORCPT ); Tue, 3 Feb 2015 19:40:17 +0100 Message-ID: <54D11608.2070408@imgtec.com> Date: Tue, 3 Feb 2015 10:40:08 -0800 From: Leonid Yegoshin MIME-Version: 1.0 Subject: Re: mips: Re-introduce copy_user_page References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1422681807-28395-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Guenter Roeck , Ralf Baechle Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Atsushi Nemoto , Matthew Wilcox Message-ID: <20150203184008.JQcTl-iYxNccKQ4gKMDu1RR8ynM1wSpmAJhZWCsFXc0@z> On 01/30/2015 09:23 PM, Guenter Roeck wrote: > Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced > the inline function copy_user_page for mips with an external reference, > but neglected to introduce the actual non-inline function. Restore it. > > Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") > Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") > Cc: Atsushi Nemoto > Cc: Matthew Wilcox > Signed-off-by: Guenter Roeck > Why do you use copy_user_page? It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. You should use copy_user_highpage() for user pages. - Leonid.