Re: [Qemu-devel] [PATCH 4/8] guest agent: add guest-pipe-open

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On 02/03/2015 02:57 PM, Eric Blake wrote:

>> +# Returns: Guest file handle on success, as per guest-file-open. This
>> +# handle is useable with the same interfaces as a handle returned by
> 

>> +  'returns': 'int' }
> 
> I'm not a fan of returning a bare 'int' - it is not extensible.  Better
> is returning a dictionary, such as 'returns': { 'fd': 'int' }.  That
> way, if we ever find a reason to return multiple pieces of information,
> we just return a larger dictionary.
> 
> Yeah, I know guest-pipe-open breaks the rules here, and so consistency
> may be an argument in favor of also breaking the rules.

I meant to say 'guest-file-open' breaks the rules, and that you are
proposing that 'guest-pipe-open' be consistent with 'guest-file-open'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]