From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2 2/3] hvm_complete_assist_req: We should
 not be able to get here on IOREQ_TYPE_PCI_CONFIG
Date: Tue, 03 Feb 2015 19:37:52 -0500
Message-ID: <54D169E0.20208@terremark.com>
References: <1422890524-19678-1-git-send-email-dslutz@verizon.com>
	<1422890524-19678-3-git-send-email-dslutz@verizon.com>
	<54D0B994020000780005C50F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54D0B994020000780005C50F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org



On 02/03/15 06:05, Jan Beulich wrote:
>>>> On 02.02.15 at 16:22, <dslutz@verizon.com> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -2573,6 +2573,7 @@ bool_t hvm_send_assist_req_to_ioreq_server(struct hvm_ioreq_server *s,
>>  
>>  static bool_t hvm_complete_assist_req(ioreq_t *p)
>>  {
>> +    ASSERT(p->type != IOREQ_TYPE_PCI_CONFIG);
>>      switch ( p->type )
>>      {
>>      case IOREQ_TYPE_COPY:
> 
> The better variant would seem to be case IOREQ_TYPE_PCI_CONFIG
> with ASSERT_UNREACHABLE().
> 

Ok, Will change (since there will be a v3)
    -Don Slutz


> Jan
>