From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: vop: power off until vop standby take effect Date: Wed, 04 Feb 2015 11:38:14 +0800 Message-ID: <54D19426.4080105@rock-chips.com> References: <1422693698-21944-1-git-send-email-mark.yao@rock-chips.com> <54CEE131.1020600@rock-chips.com> <20150202075337.GN14009@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.130]) by gabe.freedesktop.org (Postfix) with ESMTP id 866956E0ED for ; Tue, 3 Feb 2015 19:38:29 -0800 (PST) In-Reply-To: <20150202075337.GN14009@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz , David Airlie , Rob Clark , Philipp Zabel , dri-devel , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." List-Id: dri-devel@lists.freedesktop.org T24gMjAxNeW5tDAy5pyIMDLml6UgMTU6NTMsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gTW9u LCBGZWIgMDIsIDIwMTUgYXQgMTA6MzA6MDlBTSArMDgwMCwgTWFyayB5YW8gd3JvdGU6Cj4+IE9u IDIwMTXlubQwMuaciDAy5pelIDEwOjA3LCBEYW5pZWwgS3VydHogd3JvdGU6Cj4+PiBIaSBNYXJr LCBIZWlrbywKPj4+Cj4+PiBPbiBTYXQsIEphbiAzMSwgMjAxNSBhdCA0OjQxIFBNLCBNYXJrIFlh byA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+IHdyb3RlOgo+Pj4+IFZvcCBzdGFuZGJ5IHdpbGwg dGFrZSBlZmZlY3QgZW5kIG9mIGN1cnJlbnQgZnJhbWUsCj4+Pj4gaWYgZHNwX2hvbGRfdmFsaWRf aXJxIGhhcHBlbiwgaXQgbWVhbnMgdm9wIHN0YW5kYnkgY29tcGxldGUuCj4+Pj4KPj4+PiB3ZSBt dXN0IHdhaXQgc3RhbmRieSBjb21wbGV0ZSB3aGVuIHdlIHdhbnQgdG8gZGlzYWJsZSBhY2xrLAo+ Pj4+IGlmIG5vdCwgbWVtb3J5IGJ1cyBtYXliZSBkZWFkLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1i eTogTWFyayBZYW8gPG1hcmsueWFvQHJvY2stY2hpcHMuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyB8ICAgNzYgKysrKysrKysr KysrKysrKysrKysrKy0tLS0tCj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygr KSwgMTMgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9kcm1fdm9wLmMKPj4+PiBpbmRleCBmYjI1ODM2Li40N2VhNjFmIDEwMDY0NAo+Pj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPj4+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4+Pj4gQEAg LTg5LDYgKzg5LDcgQEAgc3RydWN0IHZvcCB7Cj4+Pj4gICAgICAgICAgLyogbXV0ZXggdnN5bmNf IHdvcmsgKi8KPj4+PiAgICAgICAgICBzdHJ1Y3QgbXV0ZXggdnN5bmNfbXV0ZXg7Cj4+Pj4gICAg ICAgICAgYm9vbCB2c3luY193b3JrX3BlbmRpbmc7Cj4+Pj4gKyAgICAgICBzdHJ1Y3QgY29tcGxl dGlvbiBkc3BfaG9sZF9jb21wbGV0aW9uOwo+Pj4+Cj4+Pj4gICAgICAgICAgY29uc3Qgc3RydWN0 IHZvcF9kYXRhICpkYXRhOwo+Pj4+Cj4+Pj4gQEAgLTM4Miw2ICszODMsMzQgQEAgc3RhdGljIGJv b2wgaXNfYWxwaGFfc3VwcG9ydCh1aW50MzJfdCBmb3JtYXQpCj4+Pj4gICAgICAgICAgfQo+Pj4+ ICAgfQo+Pj4+Cj4+Pj4gK3N0YXRpYyB2b2lkIHZvcF9kc3BfaG9sZF92YWxpZF9pcnFfZW5hYmxl KHN0cnVjdCB2b3AgKnZvcCkKPj4+PiArewo+Pj4+ICsgICAgICAgdW5zaWduZWQgbG9uZyBmbGFn czsKPj4+PiArCj4+Pj4gKyAgICAgICBCVUdfT04oIXZvcC0+aXNfZW5hYmxlZCk7Cj4+PiBSZTog SGVpa28gInVzZSBhIFdBUk5fT04iOgo+Pj4KPj4+IElmIHRoZSBWT1AgY2xvY2sgaXMgb2ZmLCB0 aGVuIHRoZSBzeXN0ZW0gd2lsbCBqdXN0IGhhbmcgd2hlbiB0cnlpbmcgdG8KPj4+IHdyaXRlIHRo ZSBWT1AgcmVnaXN0ZXIgc28gaW4gdGhpcyBjYXNlLCBCVUdfT04gZ2l2ZXMgYSBtb3JlIHJlbGlh YmxlCj4+PiBjcmFzaCBkdW1wIHRoYW4gdGhlIGhhbmcuCj4+ICAgIEluIHRoaXMgd2F5LCB5b3Ug YXJlIHJpZ2h0LCBpZiB2b3AgY2xvY2tzIGlzIGRpc2FibGVkLCB3cml0ZSB2b3AgcmVnaXN0ZXIK Pj4gd2lsbCBoYW5nIHN5c3RlbSwgYW5kIHRoZSBXQVJOX09OCj4gaWYgKFdBUk5fT04oY29uZCkp Cj4gCXJldHVybjsKPgo+IGlzIHdoYXQgd2UgY29tbW9ubHkgdXNlIGluIGk5MTUuIEJlY2F1c2Ug aXQncyByZWFsbHkgbm90IGFueSBnb29kIHRvIHVzZQo+IEJVR19PTiBpbiBkcm0gZHJpdmVycywg YXQgbGVhc3QgaWYgeW91IGV4cGVjdCBhbnlvbmUgdG8gdXNlIGZiY29uIG9uIHRvcAo+IG9mIGl0 IChpLmUuIGFueXRoaW5nIGV2ZW4gcmVtb3RlbHkgcmVzZW1ibGluZyBhIG5vcm1hbCBkaXN0cm8p OiBUaGVuIHRoZQo+IGludGlhbCBtb2Rlc2V0IGlzIGFsbCBkb25lIHVuZGVyIGNvbnNvbGVfbG9j aywgd2hpY2ggbWVhbnMgdGhhdCBfbm9uZV8gb2YKPiB5b3VyIEJVR19PTiB3aWxsIGV2ZXIgZ2V0 IG91dCBvdmVyIHNlcmlhbCBjb25zb2xlLgo+Cj4gVGhlIHByb2JsZW0gaXMgZmJjb24gbG9ja2lu ZywgYnV0IG5vIGZvb2wgeWV0IHNpZ25lZCB1cCB0byBmaXggaXQgKGl0J3MKPiBob3JyaWJsZSwg SSBsb29rZWQgLi4uKS4KPiAtRGFuaWVsCkkga25vdyB0aGlzIHByb2JsZW0sIGlmIGZiY29uIGxv Y2tpbmcsIGFuZCBCVUdfT04sIHdlIGNhbid0IGdldCBhbnkgbG9nIApmcm9tIHNlcmlhbCBjb25z b2xlLCBUcm91YmxlCm1lIG1hbnkgdGltZXMuIFNvIGtub3csIGlmIG5vIGRybSBsb2cgb3V0cHV0 LCB0aGUgZmlyc3QgdGhpbmcgSSBkbyBpcyAKcmVtb3ZlIHRoZSBmYmNvbiBsb2NrLCBhbmQgdGhl bgp3ZSBjYW4gc2VlIHRoZSBjcmFzaCBkdW1wLgoKQnV0IGhlcmUsIEkgZXhwZWN0IHRvIHVzZSBC VUdfT04sIGJlY2F1c2UgaWYgQlVHIGhhcHBlbiwgdm9wIHJlZ2lzdGVyIAp3aWxsIGhhbmcgc3lz dGVtLCBhbmQgV0FSTl9PTgptYXkgYmUgaGF2ZSBubyBjaGFuY2UgdG8gb3V0cHV0LgoKTWFyawoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753576AbbBDDio (ORCPT ); Tue, 3 Feb 2015 22:38:44 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:59051 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbbBDDin (ORCPT ); Tue, 3 Feb 2015 22:38:43 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: djkurtz@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54D19426.4080105@rock-chips.com> Date: Wed, 04 Feb 2015 11:38:14 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Daniel Kurtz , David Airlie , Rob Clark , Philipp Zabel , dri-devel , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." Subject: Re: [PATCH] drm/rockchip: vop: power off until vop standby take effect References: <1422693698-21944-1-git-send-email-mark.yao@rock-chips.com> <54CEE131.1020600@rock-chips.com> <20150202075337.GN14009@phenom.ffwll.local> In-Reply-To: <20150202075337.GN14009@phenom.ffwll.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年02月02日 15:53, Daniel Vetter wrote: > On Mon, Feb 02, 2015 at 10:30:09AM +0800, Mark yao wrote: >> On 2015年02月02日 10:07, Daniel Kurtz wrote: >>> Hi Mark, Heiko, >>> >>> On Sat, Jan 31, 2015 at 4:41 PM, Mark Yao wrote: >>>> Vop standby will take effect end of current frame, >>>> if dsp_hold_valid_irq happen, it means vop standby complete. >>>> >>>> we must wait standby complete when we want to disable aclk, >>>> if not, memory bus maybe dead. >>>> >>>> Signed-off-by: Mark Yao >>>> --- >>>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 76 ++++++++++++++++++++++----- >>>> 1 file changed, 63 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>> index fb25836..47ea61f 100644 >>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>> @@ -89,6 +89,7 @@ struct vop { >>>> /* mutex vsync_ work */ >>>> struct mutex vsync_mutex; >>>> bool vsync_work_pending; >>>> + struct completion dsp_hold_completion; >>>> >>>> const struct vop_data *data; >>>> >>>> @@ -382,6 +383,34 @@ static bool is_alpha_support(uint32_t format) >>>> } >>>> } >>>> >>>> +static void vop_dsp_hold_valid_irq_enable(struct vop *vop) >>>> +{ >>>> + unsigned long flags; >>>> + >>>> + BUG_ON(!vop->is_enabled); >>> Re: Heiko "use a WARN_ON": >>> >>> If the VOP clock is off, then the system will just hang when trying to >>> write the VOP register so in this case, BUG_ON gives a more reliable >>> crash dump than the hang. >> In this way, you are right, if vop clocks is disabled, write vop register >> will hang system, and the WARN_ON > if (WARN_ON(cond)) > return; > > is what we commonly use in i915. Because it's really not any good to use > BUG_ON in drm drivers, at least if you expect anyone to use fbcon on top > of it (i.e. anything even remotely resembling a normal distro): Then the > intial modeset is all done under console_lock, which means that _none_ of > your BUG_ON will ever get out over serial console. > > The problem is fbcon locking, but no fool yet signed up to fix it (it's > horrible, I looked ...). > -Daniel I know this problem, if fbcon locking, and BUG_ON, we can't get any log from serial console, Trouble me many times. So know, if no drm log output, the first thing I do is remove the fbcon lock, and then we can see the crash dump. But here, I expect to use BUG_ON, because if BUG happen, vop register will hang system, and WARN_ON may be have no chance to output. Mark