From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: vop: power off until vop standby take effect Date: Wed, 04 Feb 2015 11:56:24 +0800 Message-ID: <54D19868.8000906@rock-chips.com> References: <1422693698-21944-1-git-send-email-mark.yao@rock-chips.com> <54CEE131.1020600@rock-chips.com> <20150202075337.GN14009@phenom.ffwll.local> <54D19426.4080105@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.138]) by gabe.freedesktop.org (Postfix) with ESMTP id 16F406E15B for ; Tue, 3 Feb 2015 19:56:35 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz Cc: "linux-kernel@vger.kernel.org" , dri-devel , "open list:ARM/Rockchip SoC..." List-Id: dri-devel@lists.freedesktop.org T24gMjAxNeW5tDAy5pyIMDTml6UgMTE6NDgsIERhbmllbCBLdXJ0eiB3cm90ZToKPiBPbiBGZWIg NCwgMjAxNSAxMTozOCBBTSwgIk1hcmsgeWFvIiA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+IHdy b3RlOgo+PiBPbiAyMDE15bm0MDLmnIgwMuaXpSAxNTo1MywgRGFuaWVsIFZldHRlciB3cm90ZToK Pj4+IE9uIE1vbiwgRmViIDAyLCAyMDE1IGF0IDEwOjMwOjA5QU0gKzA4MDAsIE1hcmsgeWFvIHdy b3RlOgo+Pj4+IE9uIDIwMTXlubQwMuaciDAy5pelIDEwOjA3LCBEYW5pZWwgS3VydHogd3JvdGU6 Cj4+Pj4+IEhpIE1hcmssIEhlaWtvLAo+Pj4+Pgo+Pj4+PiBPbiBTYXQsIEphbiAzMSwgMjAxNSBh dCA0OjQxIFBNLCBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+IHdyb3RlOgo+Pj4+ Pj4gVm9wIHN0YW5kYnkgd2lsbCB0YWtlIGVmZmVjdCBlbmQgb2YgY3VycmVudCBmcmFtZSwKPj4+ Pj4+IGlmIGRzcF9ob2xkX3ZhbGlkX2lycSBoYXBwZW4sIGl0IG1lYW5zIHZvcCBzdGFuZGJ5IGNv bXBsZXRlLgo+Pj4+Pj4KPj4+Pj4+IHdlIG11c3Qgd2FpdCBzdGFuZGJ5IGNvbXBsZXRlIHdoZW4g d2Ugd2FudCB0byBkaXNhYmxlIGFjbGssCj4+Pj4+PiBpZiBub3QsIG1lbW9yeSBidXMgbWF5YmUg ZGVhZC4KPj4+Pj4+Cj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8bWFyay55YW9Acm9j ay1jaGlwcy5jb20+Cj4+Pj4+PiAtLS0KPj4+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9yb2NrY2hpcF9kcm1fdm9wLmMgfCAgIDc2ICsrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ Pj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygt KQo+Pj4+Pj4KPj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9j a2NoaXBfZHJtX3ZvcC5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92 b3AuYwo+Pj4+Pj4gaW5kZXggZmIyNTgzNi4uNDdlYTYxZiAxMDA2NDQKPj4+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPj4+Pj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPj4+Pj4+IEBAIC04OSw2 ICs4OSw3IEBAIHN0cnVjdCB2b3Agewo+Pj4+Pj4gICAgICAgICAgIC8qIG11dGV4IHZzeW5jXyB3 b3JrICovCj4+Pj4+PiAgICAgICAgICAgc3RydWN0IG11dGV4IHZzeW5jX211dGV4Owo+Pj4+Pj4g ICAgICAgICAgIGJvb2wgdnN5bmNfd29ya19wZW5kaW5nOwo+Pj4+Pj4gKyAgICAgICBzdHJ1Y3Qg Y29tcGxldGlvbiBkc3BfaG9sZF9jb21wbGV0aW9uOwo+Pj4+Pj4KPj4+Pj4+ICAgICAgICAgICBj b25zdCBzdHJ1Y3Qgdm9wX2RhdGEgKmRhdGE7Cj4+Pj4+Pgo+Pj4+Pj4gQEAgLTM4Miw2ICszODMs MzQgQEAgc3RhdGljIGJvb2wgaXNfYWxwaGFfc3VwcG9ydCh1aW50MzJfdCBmb3JtYXQpCj4+Pj4+ PiAgICAgICAgICAgfQo+Pj4+Pj4gICAgfQo+Pj4+Pj4KPj4+Pj4+ICtzdGF0aWMgdm9pZCB2b3Bf ZHNwX2hvbGRfdmFsaWRfaXJxX2VuYWJsZShzdHJ1Y3Qgdm9wICp2b3ApCj4+Pj4+PiArewo+Pj4+ Pj4gKyAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAgICBC VUdfT04oIXZvcC0+aXNfZW5hYmxlZCk7Cj4+Pj4+IFJlOiBIZWlrbyAidXNlIGEgV0FSTl9PTiI6 Cj4+Pj4+Cj4+Pj4+IElmIHRoZSBWT1AgY2xvY2sgaXMgb2ZmLCB0aGVuIHRoZSBzeXN0ZW0gd2ls bCBqdXN0IGhhbmcgd2hlbiB0cnlpbmcgdG8KPj4+Pj4gd3JpdGUgdGhlIFZPUCByZWdpc3RlciBz byBpbiB0aGlzIGNhc2UsIEJVR19PTiBnaXZlcyBhIG1vcmUgcmVsaWFibGUKPj4+Pj4gY3Jhc2gg ZHVtcCB0aGFuIHRoZSBoYW5nLgo+Pj4+ICAgICBJbiB0aGlzIHdheSwgeW91IGFyZSByaWdodCwg aWYgdm9wIGNsb2NrcyBpcyBkaXNhYmxlZCwgd3JpdGUgdm9wIHJlZ2lzdGVyCj4+Pj4gd2lsbCBo YW5nIHN5c3RlbSwgYW5kIHRoZSBXQVJOX09OCj4+PiBpZiAoV0FSTl9PTihjb25kKSkKPj4+ICAg ICAgICAgIHJldHVybjsKPj4+Cj4+PiBpcyB3aGF0IHdlIGNvbW1vbmx5IHVzZSBpbiBpOTE1LiBC ZWNhdXNlIGl0J3MgcmVhbGx5IG5vdCBhbnkgZ29vZCB0byB1c2UKPj4+IEJVR19PTiBpbiBkcm0g ZHJpdmVycywgYXQgbGVhc3QgaWYgeW91IGV4cGVjdCBhbnlvbmUgdG8gdXNlIGZiY29uIG9uIHRv cAo+Pj4gb2YgaXQgKGkuZS4gYW55dGhpbmcgZXZlbiByZW1vdGVseSByZXNlbWJsaW5nIGEgbm9y bWFsIGRpc3Rybyk6IFRoZW4gdGhlCj4+PiBpbnRpYWwgbW9kZXNldCBpcyBhbGwgZG9uZSB1bmRl ciBjb25zb2xlX2xvY2ssIHdoaWNoIG1lYW5zIHRoYXQgX25vbmVfIG9mCj4+PiB5b3VyIEJVR19P TiB3aWxsIGV2ZXIgZ2V0IG91dCBvdmVyIHNlcmlhbCBjb25zb2xlLgo+Pj4KPj4+IFRoZSBwcm9i bGVtIGlzIGZiY29uIGxvY2tpbmcsIGJ1dCBubyBmb29sIHlldCBzaWduZWQgdXAgdG8gZml4IGl0 IChpdCdzCj4+PiBob3JyaWJsZSwgSSBsb29rZWQgLi4uKS4KPj4+IC1EYW5pZWwKPj4gSSBrbm93 IHRoaXMgcHJvYmxlbSwgaWYgZmJjb24gbG9ja2luZywgYW5kIEJVR19PTiwgd2UgY2FuJ3QgZ2V0 IGFueSBsb2cgZnJvbSBzZXJpYWwgY29uc29sZSwgVHJvdWJsZQo+PiBtZSBtYW55IHRpbWVzLiBT byBrbm93LCBpZiBubyBkcm0gbG9nIG91dHB1dCwgdGhlIGZpcnN0IHRoaW5nIEkgZG8gaXMgcmVt b3ZlIHRoZSBmYmNvbiBsb2NrLCBhbmQgdGhlbgo+PiB3ZSBjYW4gc2VlIHRoZSBjcmFzaCBkdW1w Lgo+Pgo+PiBCdXQgaGVyZSwgSSBleHBlY3QgdG8gdXNlIEJVR19PTiwgYmVjYXVzZSBpZiBCVUcg aGFwcGVuLCB2b3AgcmVnaXN0ZXIgd2lsbCBoYW5nIHN5c3RlbSwgYW5kIFdBUk5fT04KPj4gbWF5 IGJlIGhhdmUgbm8gY2hhbmNlIHRvIG91dHB1dC4KPiBZZWFoLCBidXQgZGFudmV0IGlzIHN1Z2dl c3Rpbmcgd2UganVzdCByZXR1cm4gaW1tZWRpYXRlbHkgb24gdGhlCj4gV0FSTl9PTiBjb25kaXRp b24sIHRvIGF2b2lkIGFjY2Vzc2luZyB0aGUgdm9wIHJlZ2lzdGVycyBhbmQgaGFuZ2luZy4KPgo+ IFRodXMsIHRoZSBXQVJOX09OIHdpbGwgaGF2ZSBhIGNoYW5jZSB0byBwdXQgb3V0ICh1bmxlc3Mg dGhlIGVhcmx5Cj4gcmV0dXJuIHBhdGggZ29lcyBvZmYgYW5kIGZpbmRzIHNvbWUgb3RoZXIgdW5w cm90ZWN0ZWQgcGF0aCBnb2VzIHRvCj4gYWNjZXNzIHVubG9ja2VkIHJlZ2lzdGVycykuCj4KPiAt RGFuCkFsbCByaWdodCwgSSBnb3QgaXQuCj4+IE1hcmsKPj4KPgo+CgoKLS0gCu+8rWFyayBZYW8g 5aea5pm65oOFCgpSb2NrY2hpcCDnpo/lt57nkZ7oiq/lvq7nlLXlrZDmnInpmZDlhazlj7gKCkZ1 emhvdSBIZWFkcXVhcnRlcnMKCkFkZHI6Tm8uMjEgQnVpbGRpbmcsIEEgRGlzdHJpY3QsIEZ1emhv dQoKU29mdHdhcmUgUGFyaywgODkgU29mdCBBdmVudWUsIFRvbmdwYW4gUm9hZCwKCkd1bG91IERp c3RyaWN0LCBGdXpob3UgKDM1MDAwMykKCuWcsOWdgDrnpo/lu7rnnIHnpo/lt57luILpk5znm5jo t6/ova/ku7blpKfpgZM4OeWPt+i9r+S7tuWbrUHljLoyMeWPt+alvCAoMzUwMDAzKQoKVGVsOu+8 iDg2LTA1OTHvvIk4Mzk5MTkwNiAtIDgyOTYKCkUtbWFpbDptYXJrLnlhb0Byb2NrLWNoaXBzLmNv bQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbbBDD4f (ORCPT ); Tue, 3 Feb 2015 22:56:35 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:60338 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbBDD4e (ORCPT ); Tue, 3 Feb 2015 22:56:34 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: djkurtz@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <1144afd3bc913c840dd970b8a21de2b0> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54D19868.8000906@rock-chips.com> Date: Wed, 04 Feb 2015 11:56:24 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Daniel Kurtz CC: "linux-kernel@vger.kernel.org" , dri-devel , Philipp Zabel , David Airlie , Rob Clark , "open list:ARM/Rockchip SoC..." Subject: Re: [PATCH] drm/rockchip: vop: power off until vop standby take effect References: <1422693698-21944-1-git-send-email-mark.yao@rock-chips.com> <54CEE131.1020600@rock-chips.com> <20150202075337.GN14009@phenom.ffwll.local> <54D19426.4080105@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年02月04日 11:48, Daniel Kurtz wrote: > On Feb 4, 2015 11:38 AM, "Mark yao" wrote: >> On 2015年02月02日 15:53, Daniel Vetter wrote: >>> On Mon, Feb 02, 2015 at 10:30:09AM +0800, Mark yao wrote: >>>> On 2015年02月02日 10:07, Daniel Kurtz wrote: >>>>> Hi Mark, Heiko, >>>>> >>>>> On Sat, Jan 31, 2015 at 4:41 PM, Mark Yao wrote: >>>>>> Vop standby will take effect end of current frame, >>>>>> if dsp_hold_valid_irq happen, it means vop standby complete. >>>>>> >>>>>> we must wait standby complete when we want to disable aclk, >>>>>> if not, memory bus maybe dead. >>>>>> >>>>>> Signed-off-by: Mark Yao >>>>>> --- >>>>>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 76 ++++++++++++++++++++++----- >>>>>> 1 file changed, 63 insertions(+), 13 deletions(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>>>> index fb25836..47ea61f 100644 >>>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>>>> @@ -89,6 +89,7 @@ struct vop { >>>>>> /* mutex vsync_ work */ >>>>>> struct mutex vsync_mutex; >>>>>> bool vsync_work_pending; >>>>>> + struct completion dsp_hold_completion; >>>>>> >>>>>> const struct vop_data *data; >>>>>> >>>>>> @@ -382,6 +383,34 @@ static bool is_alpha_support(uint32_t format) >>>>>> } >>>>>> } >>>>>> >>>>>> +static void vop_dsp_hold_valid_irq_enable(struct vop *vop) >>>>>> +{ >>>>>> + unsigned long flags; >>>>>> + >>>>>> + BUG_ON(!vop->is_enabled); >>>>> Re: Heiko "use a WARN_ON": >>>>> >>>>> If the VOP clock is off, then the system will just hang when trying to >>>>> write the VOP register so in this case, BUG_ON gives a more reliable >>>>> crash dump than the hang. >>>> In this way, you are right, if vop clocks is disabled, write vop register >>>> will hang system, and the WARN_ON >>> if (WARN_ON(cond)) >>> return; >>> >>> is what we commonly use in i915. Because it's really not any good to use >>> BUG_ON in drm drivers, at least if you expect anyone to use fbcon on top >>> of it (i.e. anything even remotely resembling a normal distro): Then the >>> intial modeset is all done under console_lock, which means that _none_ of >>> your BUG_ON will ever get out over serial console. >>> >>> The problem is fbcon locking, but no fool yet signed up to fix it (it's >>> horrible, I looked ...). >>> -Daniel >> I know this problem, if fbcon locking, and BUG_ON, we can't get any log from serial console, Trouble >> me many times. So know, if no drm log output, the first thing I do is remove the fbcon lock, and then >> we can see the crash dump. >> >> But here, I expect to use BUG_ON, because if BUG happen, vop register will hang system, and WARN_ON >> may be have no chance to output. > Yeah, but danvet is suggesting we just return immediately on the > WARN_ON condition, to avoid accessing the vop registers and hanging. > > Thus, the WARN_ON will have a chance to put out (unless the early > return path goes off and finds some other unprotected path goes to > access unlocked registers). > > -Dan All right, I got it. >> Mark >> > > -- Ｍark Yao 姚智情 Rockchip 福州瑞芯微电子有限公司 Fuzhou Headquarters Addr:No.21 Building, A District, Fuzhou Software Park, 89 Soft Avenue, Tongpan Road, Gulou District, Fuzhou (350003) 地址:福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003) Tel:（86-0591）83991906 - 8296 E-mail:mark.yao@rock-chips.com