From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART
Date: Wed, 04 Feb 2015 09:34:13 +0100 [thread overview]
Message-ID: <54D1D985.8040104@redhat.com> (raw)
In-Reply-To: <1423038452.12551.32.camel@hellion.org.uk>
Hi,
On 04-02-15 09:27, Ian Campbell wrote:
> On Wed, 2015-02-04 at 00:43 +0100, Hans de Goede wrote:
>> The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be
>> defined, as the default bootcmd not uses the "part" command.
> ^w
>
> Shouldn't config_distro_bootcmd.h (or perhaps config_distro_defaults.h)
> enable CMD_PART then? (adding some relevant CCs)
I was thinking the same myself, but I was not sure, so I thought lets go
with a quick fix for now and discuss this further on the list :)
A quick grep shows that config_distro_bootcmd.h is only included from
headers under include/configs/*.h, so enabling it there should get it
defined early enough for it to be properly picked up, so from my
pov yes that is a better solution.
Regards,
Hans
p.s.
Have you seen my reply to your review of "[PATCH 1/2] sunxi: video: Do not use CONFIG_SYS_MEM_TOP_HIDE for the framebuffer" ?
I'm waiting on input from you there on the fdt_fixup_memory_banks()
thingie, which I would prefer to keep as is. An "Acked-by" under
the condition that I fix up the Linux specific comments would be
welcome :)
>
> Ian.
>
>> This fixes sunxi boards not booting with v2015.04-rc1.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> include/configs/sunxi-common.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
>> index bf60dcb..9e145f0 100644
>> --- a/include/configs/sunxi-common.h
>> +++ b/include/configs/sunxi-common.h
>> @@ -144,6 +144,9 @@
>> #define CONFIG_CMD_MEMORY
>> #define CONFIG_CMD_SETEXPR
>>
>> +#define CONFIG_PARTITION_UUIDS
>> +#define CONFIG_CMD_PART
>> +
>> #define CONFIG_SETUP_MEMORY_TAGS
>> #define CONFIG_CMDLINE_TAG
>> #define CONFIG_INITRD_TAG
>
>
next prev parent reply other threads:[~2015-02-04 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 23:43 [U-Boot] [PATCH] sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART Hans de Goede
2015-02-04 8:27 ` Ian Campbell
2015-02-04 8:34 ` Hans de Goede [this message]
2015-02-04 16:57 ` Stephen Warren
2015-02-12 0:44 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D1D985.8040104@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.