From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>,
Olivier Sobrie <olivier@sobrie.be>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>,
Andri Yngvason <andri.yngvason@marel.com>
Cc: Linux-CAN <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: kvaser_usb: Ignore spurious error events after a busoff
Date: Wed, 04 Feb 2015 14:04:35 +0100 [thread overview]
Message-ID: <54D218E3.3050204@pengutronix.de> (raw)
In-Reply-To: <20150202201555.GA29327@linux>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On 02/02/2015 09:15 PM, Ahmed S. Darwish wrote:
> From: Ahmed S. Darwish <ahmed.darwish@valeo.com>
>
> Sending data in high speed then introducing a busoff results
> in spurious BUS_ERROR events from the USBCan-II firmware directly
> _after_ the triggered BUS_OFF event.
>
> In the current CAN state handling code, this will lead to an
> invalid can state of ACTIVE, ERROR, or PASSIVE even though the
> CAN controller has been already shut down due to the busoff.
>
> Guard the state handling code from such invalid events.
>
> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>
Applied to can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-02-04 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 20:15 [PATCH] can: kvaser_usb: Ignore spurious error events after a busoff Ahmed S. Darwish
2015-02-04 13:04 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D218E3.3050204@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andri.yngvason@marel.com \
--cc=darwish.07@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=olivier@sobrie.be \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.