All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	kernel@pengutronix.de, Steve Longerbeam <slongerbeam@gmail.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v2 05/10] Add RGB666_1X24_CPADHI media bus format
Date: Wed, 04 Feb 2015 16:37:36 +0200	[thread overview]
Message-ID: <54D22EB0.1080602@linux.intel.com> (raw)
In-Reply-To: <1422988504-11123-6-git-send-email-p.zabel@pengutronix.de>

Hi Philipp,

Could you add linux-media next time you send the set, please? I think 
that's the most relevant list for the format related patches.

Philipp Zabel wrote:
> Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel
> display") describes a 24-bit bus format where three 6-bit components each
> take the lower part of 8 bits with the two high bits zero padded. Add a
> component-wise padded media bus format RGB666_1X24_CPADHI to support this
> connection.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++
>   include/uapi/linux/media-bus-format.h              |  3 ++-
>   2 files changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> index 8d1f624..c02af7a 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -480,6 +480,36 @@ see <xref linkend="colorspaces" />.</entry>
>   	      <entry>b<subscript>1</subscript></entry>
>   	      <entry>b<subscript>0</subscript></entry>
>   	    </row>
> +	    <row id="MEDIA-BUS-FMT-RGB666-1X24_CPADHI">
> +	      <entry>MEDIA_BUS_FMT_RGB666_1X24_CPADHI</entry>

Could you add a note on "C" in front of PADHI to the explanation in 
media-bus-format.h?

> +	      <entry>0x1015</entry>
> +	      <entry></entry>
> +	      &dash-ent-8;
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>r<subscript>5</subscript></entry>
> +	      <entry>r<subscript>4</subscript></entry>
> +	      <entry>r<subscript>3</subscript></entry>
> +	      <entry>r<subscript>2</subscript></entry>
> +	      <entry>r<subscript>1</subscript></entry>
> +	      <entry>r<subscript>0</subscript></entry>
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>g<subscript>5</subscript></entry>
> +	      <entry>g<subscript>4</subscript></entry>
> +	      <entry>g<subscript>3</subscript></entry>
> +	      <entry>g<subscript>2</subscript></entry>
> +	      <entry>g<subscript>1</subscript></entry>
> +	      <entry>g<subscript>0</subscript></entry>
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>b<subscript>5</subscript></entry>
> +	      <entry>b<subscript>4</subscript></entry>
> +	      <entry>b<subscript>3</subscript></entry>
> +	      <entry>b<subscript>2</subscript></entry>
> +	      <entry>b<subscript>1</subscript></entry>
> +	      <entry>b<subscript>0</subscript></entry>
> +	    </row>
>   	    <row id="MEDIA-BUS-FMT-BGR888-1X24">
>   	      <entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
>   	      <entry>0x1013</entry>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 8dbf16c..83ea46f 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -33,7 +33,7 @@
>
>   #define MEDIA_BUS_FMT_FIXED			0x0001
>
> -/* RGB - next is	0x1015 */
> +/* RGB - next is	0x1016 */
>   #define MEDIA_BUS_FMT_RGB444_1X12		0x100e
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
> @@ -45,6 +45,7 @@
>   #define MEDIA_BUS_FMT_RGB565_2X8_BE		0x1007
>   #define MEDIA_BUS_FMT_RGB565_2X8_LE		0x1008
>   #define MEDIA_BUS_FMT_RGB666_1X18		0x1009
> +#define MEDIA_BUS_FMT_RGB666_1X24_CPADHI	0x1015
>   #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG		0x1010
>   #define MEDIA_BUS_FMT_BGR888_1X24		0x1013
>   #define MEDIA_BUS_FMT_GBR888_1X24		0x1014
>

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-02-04 14:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 18:34 [PATCH v2 00/10] Use media bus formats in imx-drm and add drm panel support Philipp Zabel
2015-02-03 18:34 ` [PATCH v2 01/10] Add RGB444_1X12 and RGB565_1X16 media bus formats Philipp Zabel
2015-02-03 18:34 ` [PATCH v2 02/10] Add LVDS RGB " Philipp Zabel
2015-02-03 18:34 ` [PATCH v2 03/10] Add BGR888_1X24 and GBR888_1X24 " Philipp Zabel
2015-02-03 18:34 ` [PATCH v2 04/10] Add YUV8_1X24 media bus format Philipp Zabel
2015-02-03 18:34 ` [PATCH v2 05/10] Add RGB666_1X24_CPADHI " Philipp Zabel
2015-02-04 14:37   ` Sakari Ailus [this message]
2015-02-05  9:42     ` Philipp Zabel
2015-02-05 10:04       ` Sakari Ailus
2015-02-03 18:35 ` [PATCH v2 06/10] drm/imx: switch to use media bus formats Philipp Zabel
2015-02-03 18:35 ` [PATCH v2 07/10] drm/imx: consolidate bus format variable names Philipp Zabel
2015-02-03 18:35 ` [PATCH v2 08/10] drm/imx: imx-ldb: add drm_panel support Philipp Zabel
2015-02-03 18:35 ` [PATCH v2 09/10] drm/imx: imx-ldb: reset display clock input when disabling LVDS Philipp Zabel
2015-02-03 18:35 ` [PATCH v2 10/10] drm/imx: imx-ldb: allow to determine bus format from the connected panel Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D22EB0.1080602@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hans.verkuil@cisco.com \
    --cc=kernel@esmil.dk \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=mchehab@osg.samsung.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.