From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ1A2-0007of-8e for qemu-devel@nongnu.org; Wed, 04 Feb 2015 09:42:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ19x-0006CC-T6 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 09:42:34 -0500 Received: from mx2.parallels.com ([199.115.105.18]:47345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ19x-0006Bj-Nc for qemu-devel@nongnu.org; Wed, 04 Feb 2015 09:42:29 -0500 Message-ID: <54D22FC8.9060504@parallels.com> Date: Wed, 4 Feb 2015 17:42:16 +0300 From: Vladimir Sementsov-Ogievskiy MIME-Version: 1.0 References: <1422356197-5285-1-git-send-email-vsementsov@parallels.com> <1422356197-5285-8-git-send-email-vsementsov@parallels.com> <54C7BABB.9070304@redhat.com> In-Reply-To: <54C7BABB.9070304@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 7/8] migration: add dirty parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On 27.01.2015 19:20, Eric Blake wrote: > On 01/27/2015 03:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add dirty parameter to qmp-migrate command. If this parameter is true, >> migration/block.c will migrate dirty bitmaps. This parameter can be used >> without "blk" parameter to migrate only dirty bitmaps, skipping block >> migration. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> +++ b/qapi-schema.json >> @@ -1656,12 +1656,17 @@ >> # @detach: this argument exists only for compatibility reasons and >> # is ignored by QEMU >> # >> +# @dirty: #optional do dirty-bitmaps migration (can be used with or without >> +# @blk parameter) >> +# (since 2.3) > Rather than adding it to 'migrate', where the command is not > introspectible, I'd rather you add it to 'migrate-set-capabilities', > where I can then use 'query-migrate-capabilities' to learn if it is > supported. > Thank you. Moreover, it is turned out to be a simpler way than with migration parameter. I've done the change, it will be in v3. I'm just waiting for review of the core part of the series - migration/dirty-bitmap.c -- Best regards, Vladimir