From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YJ1mt-0002F8-B2 for ath10k@lists.infradead.org; Wed, 04 Feb 2015 15:22:43 +0000 Message-ID: <54D23974.1070206@candelatech.com> Date: Wed, 04 Feb 2015 07:23:32 -0800 From: Ben Greear MIME-Version: 1.0 Subject: Re: More than one ath10k NIC will not load (bisected) References: <54BECE4D.9020308@candelatech.com> <54BF0B42.7050101@dd-wrt.com> <54BF13AE.5010909@candelatech.com> <54BFF788.2000500@candelatech.com> <54C00239.7000008@candelatech.com> <54C166B8.7060405@candelatech.com> <54C26EB3.7050805@candelatech.com> <87vbjit58l.fsf@kamboji.qca.qualcomm.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior , Kalle Valo Cc: "ath10k@lists.infradead.org" On 02/04/2015 01:35 AM, Michal Kazior wrote: > On 4 February 2015 at 10:07, Kalle Valo wrote: >> Ben Greear writes: >> >>>> Hmm.. This removes warm_reset in probe function but I fail to see how >>>> this could end up not loading one of the NIC *silently*? >>>> >>>> Anyway there's a pending patch which adds the reset back: >>>> https://github.com/kvalo/ath/commit/bdcd6f4e4ac5d2d2a56da4813f56655e6db0ee45 >>>> . You might want to try it and see if it helps. >>> >>> Reverting the patch made it work again for me. >>> >>> I don't understand that code well, but perhaps you are disabling >>> a shared interrupt that silently stops the second NIC from >>> being able to do it's thing? >>> >>> Do you have a PC with 2 NICs in it that you could try yourself? >>> >>> I can grab you the logs of a failure to boot later today. >> >> What should we do with this one? I didn't look at the details yet, but >> do we have any other option than to revert? > > I believe this is an issue in Ben's userspace (he sent me logs > privately) or some sort of kernel event bug. It basically looked like > this: both devices were detected by ath10k and both started > register_work. One of the devices loaded all the way while the other > tried to load a few non-existing firmware files and it stopped. Few > minutes later there was a hung task splat pointing to > request_firmware() called from ath10k suggesting userspace didn't > handle firmware request. > > The "offending" patch effectively removed 200ms from probe() in > ath10k. This could've change timing on request_firmware() calls on > Ben's system. Btw. the 200ms is back again now with > 1a7fecb766c83dace747f42b25bbb544b00a0163 ("ath10k: reset chip before > reading chip_id in probe"). > > Marek tried running 2 qca988x on his laptop some time ago (with and > without the extra timing) and didn't have any issues. I can retry my system with stock Fedora 20 and see if it works there. If not, then I think it still needs to be worked on...you agree? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k