From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
james.hogan@imgtec.com, mst@redhat.com, jan.kiszka@siemens.com,
cornelia.huck@de.ibm.com, agraf@suse.de, borntraeger@de.ibm.com,
scottwood@freescale.com, leon.alrae@imgtec.com,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts
Date: Wed, 04 Feb 2015 17:00:48 +0100 [thread overview]
Message-ID: <54D24230.1020602@redhat.com> (raw)
In-Reply-To: <1423064635-19045-1-git-send-email-marcel@redhat.com>
On 04/02/2015 16:43, Marcel Apfelbaum wrote:
> Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option
> descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties.
>
> This results in a Qemu crash if a non string option is queried using qemu opts.
> Fix this by querying machine properties through designated wrappers.
Wrappers vs. direct access to fields is just a matter of taste, so
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-02-04 16:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 15:43 [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 1/8] machine: query iommu machine property " Marcel Apfelbaum
2015-02-04 16:47 ` Markus Armbruster
2015-02-04 19:30 ` Marcel Apfelbaum
2015-02-05 8:18 ` Markus Armbruster
2015-03-11 14:43 ` Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 2/8] hw/machine: kernel-irqchip property support for allowed/required Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 3/8] machine: query kernel-irqchip machine property rather than qemu opts Marcel Apfelbaum
2015-03-11 14:41 ` Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 4/8] kvm: add machine state to kvm_arch_init Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 5/8] machine: query kvm-shadow-mem machine property rather than qemu opts Marcel Apfelbaum
2015-03-11 14:37 ` Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 6/8] machine: query phandle-start " Marcel Apfelbaum
2015-03-11 14:32 ` Marcel Apfelbaum
2015-03-11 14:34 ` Marcel Apfelbaum
2015-03-11 14:39 ` Michael S. Tsirkin
2015-03-11 14:48 ` Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core " Marcel Apfelbaum
2015-03-10 17:50 ` Andreas Färber
2015-03-10 21:24 ` Michael S. Tsirkin
2015-03-10 21:36 ` Andreas Färber
2015-03-11 7:34 ` Markus Armbruster
2015-03-11 8:45 ` Michael S. Tsirkin
2015-03-11 9:42 ` Marcel Apfelbaum
2015-03-11 8:56 ` Michael S. Tsirkin
2015-03-11 11:06 ` Andreas Färber
2015-03-11 13:04 ` Marcel Apfelbaum
2015-03-11 14:22 ` Michael S. Tsirkin
2015-03-11 15:08 ` Markus Armbruster
2015-03-11 9:44 ` Marcel Apfelbaum
2015-03-11 14:25 ` Marcel Apfelbaum
2015-02-04 15:43 ` [Qemu-devel] [PATCH 8/8] machine: query mem-merge " Marcel Apfelbaum
2015-03-10 15:11 ` Michael S. Tsirkin
2015-03-10 16:22 ` Marcel Apfelbaum
2015-02-04 16:00 ` Paolo Bonzini [this message]
2015-02-04 19:45 ` [Qemu-devel] [PATCH 0/8] machine: query machine properties " Christian Borntraeger
2015-02-04 21:35 ` Marcel Apfelbaum
2015-02-04 22:10 ` Christian Borntraeger
2015-02-25 11:55 ` Marcel Apfelbaum
2015-03-04 15:37 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D24230.1020602@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=jan.kiszka@siemens.com \
--cc=leon.alrae@imgtec.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.