Re: [Qemu-devel] [PATCH RFC v3 1/6] qemu-iotests: fix tests 067, 071 and 087

[Max Reitz <mreitz@redhat.com>]

On 2015-02-04 at 04:32, Xiao Guang Chen wrote:
> From: Xiao Guang Chen <chenxg@cn.ibm.com>
>
> Update the output files for test case 067, 071 and 087 because qemu option
> -nodefaults was used to start a guest so there are no default floppy and
> cdrom for guests any more.
> Use virtio-blk instead of virtio-blk-pci as the device driver for test case
> 067. For virtio-blk-pci is the same with virtio-blk as device driver but
> other platform such as s390 may not recognize the virtio-blk-pci.
>
> Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
> ---
>   tests/qemu-iotests/067     |  8 ++++----
>   tests/qemu-iotests/067.out | 26 +++++++++-----------------
>   tests/qemu-iotests/071.out | 12 ++++--------
>   tests/qemu-iotests/087.out | 18 +++---------------
>   4 files changed, 20 insertions(+), 44 deletions(-)

First of all, this patch needs to be rebased (it doesn't apply on qemu's 
current master branch any more (without manual fixing)).

Second, I think this patch belongs after patch 3 (or should be squashed 
into it, considering that commits should not break tests), because as it 
is here, it breaks these tests on x86.

Max